Page MenuHomePhabricator

[Follow up work] Restrict click tracking to A, BUTTON and INPUT tags
Closed, ResolvedPublic2 Estimated Story Points

Description

As follow up to T352075, we want to restrict click tracking via the data-event-name attribute to only apply to certain tags, to avoid the situation where clicking a single element can trigger multiple events (e.g. in the case of clicking a LABEL element). As currently written our instrumentation could give the impression certain elements are clicked more than twice the normal rate.

As part of this we're adding tests.

QA steps

  • Check that clicking radio buttons in the client preferences triggers events
  • Check that clicking links in the Vector menus trigger events

QA Results - Beta

ACStatusDetails
1T352566#9422739
2T352566#9422739

QA Results - Production

ACStatusDetails
1T352566#9436280
2T352566#9436280

Event Timeline

Jdlrobson lowered the priority of this task from High to Medium.

Change 977811 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Add tests for click tracking

https://gerrit.wikimedia.org/r/977811

Change 978158 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] Limit click tracking to buttons, anchors and inputs

https://gerrit.wikimedia.org/r/978158

Jdlrobson added a subscriber: phuedx.

I will rebase this and then assign to Kim for code review.

Change 977811 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Add tests for click tracking and reorganize click tracking code

https://gerrit.wikimedia.org/r/977811

Change 978158 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Limit click tracking to buttons, anchors and inputs

https://gerrit.wikimedia.org/r/978158

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: KSarabia-WMF.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Check that clicking radio buttons in the client preferences triggers events

screenshot 194.mov.gif (1×1 px, 1 MB)

✅ AC2: Check that clicking links in the Vector menus trigger events

screenshot 385.png (511×797 px, 100 KB)

screenshot 384.png (512×817 px, 99 KB)

Jdlrobson claimed this task.

Test Result - test.wikipedia.org

Status: ✅ PASS
Environment: test.wikipedia.org
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Check that clicking radio buttons in the client preferences triggers events

Screenshot 2024-01-04 at 12.41.26 PM.png (266×623 px, 48 KB)

✅ AC2: Check that clicking links in the Vector menus trigger events

Screenshot 2024-01-04 at 12.42.01 PM.png (278×590 px, 46 KB)