Page MenuHomePhabricator
Create Task
Maniphest T352768

Migrate Codex CI from Node 16 to Node 18
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
jjb: Drop branchdeploy-codex-node16-npm-docker, no longer usedintegration/configmaster+0 -1
Zuul: [design/codex] Switch to Node 18integration/configmaster+3 -3
jjb: Migrate codex-docker-doc-* to Node 18integration/configmaster+3 -3
jjb: Provide branchdeploy-codex-node18-npm-dockerintegration/configmaster+30 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Dec 5 2023, 1:54 PM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptDec 5 2023, 1:54 PM
gerritbot added a comment.Dec 5 2023, 1:54 PM

Change 980388 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Provide branchdeploy-codex-node18-npm-docker

https://gerrit.wikimedia.org/r/980388

gerritbot added a project: Patch-For-Review.Dec 5 2023, 1:54 PM

Change 980389 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Migrate codex-docker-doc-* to Node 18

https://gerrit.wikimedia.org/r/980389

gerritbot added a comment.Dec 5 2023, 1:54 PM

Change 980390 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [design/codex] Switch to Node 18

https://gerrit.wikimedia.org/r/980390

gerritbot added a comment.Dec 5 2023, 1:59 PM

Change 980393 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Drop branchdeploy-codex-node16-npm-docker, no longer used

https://gerrit.wikimedia.org/r/980393

Jdforrester-WMF added a comment.Dec 5 2023, 2:00 PM

@egardner I've teed-up the patches to switch Codex, but I've not deployed them yet – just shout and I can deploy.

gerritbot added a comment.Dec 5 2023, 2:00 PM

Change 980388 merged by jenkins-bot:

[integration/config@master] jjb: Provide branchdeploy-codex-node18-npm-docker

https://gerrit.wikimedia.org/r/980388

Jdforrester-WMF added a comment.Dec 5 2023, 2:49 PM
In T352768#9382994, @Jdforrester-WMF wrote:

@egardner I've teed-up the patches to switch Codex, but I've not deployed them yet – just shout and I can deploy.

As a point of info, having run the node18 and node20 jobs as experimental, they both pass:

https://integration.wikimedia.org/ci/job/generic-node18-browser-docker/1/console

https://integration.wikimedia.org/ci/job/generic-node20-browser-docker/1/console

CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.Dec 6 2023, 4:43 PM
egardner added a parent task: T352587: Upgrade Codex to Vite 5.x and Vitepress 1.0.Dec 6 2023, 11:54 PM
egardner added a comment.Dec 7 2023, 11:05 PM
In T352768#9382994, @Jdforrester-WMF wrote:

@egardner I've teed-up the patches to switch Codex, but I've not deployed them yet – just shout and I can deploy.

Hey James, thanks for doing this! I think we can safely move Codex CI to Node 18 at this point. Should I +2 https://gerrit.wikimedia.org/r/c/integration/config/+/980389/1 and https://gerrit.wikimedia.org/r/c/integration/config/+/980390/ to facilitate that?

gerritbot added a comment.Dec 11 2023, 9:16 PM

Change 980389 merged by jenkins-bot:

[integration/config@master] jjb: Migrate codex-docker-doc-* to Node 18

https://gerrit.wikimedia.org/r/980389

gerritbot added a comment.Dec 11 2023, 9:16 PM

Change 980390 merged by jenkins-bot:

[integration/config@master] Zuul: [design/codex] Switch to Node 18

https://gerrit.wikimedia.org/r/980390

Stashbot added a comment.Dec 11 2023, 9:17 PM

Mentioned in SAL (#wikimedia-releng) [2023-12-11T21:17:34Z] <James_F> Zuul: [design/codex] Switch to Node 18 for T352768

CCiufo-WMF moved this task from Up Next to Following on the Design-System-Team board.Dec 11 2023, 9:22 PM
Jdforrester-WMF closed this task as Resolved.Dec 11 2023, 9:31 PM
Jdforrester-WMF claimed this task.
In T352768#9392102, @egardner wrote:
In T352768#9382994, @Jdforrester-WMF wrote:

@egardner I've teed-up the patches to switch Codex, but I've not deployed them yet – just shout and I can deploy.

Hey James, thanks for doing this! I think we can safely move Codex CI to Node 18 at this point.

This is now live. Test re-runs on 980447 worked as expected. Please shout if anything is broken!

egardner added a comment.Dec 11 2023, 9:36 PM
In T352768#9398075, @Jdforrester-WMF wrote:
In T352768#9392102, @egardner wrote:
In T352768#9382994, @Jdforrester-WMF wrote:

@egardner I've teed-up the patches to switch Codex, but I've not deployed them yet – just shout and I can deploy.

Hey James, thanks for doing this! I think we can safely move Codex CI to Node 18 at this point.

This is now live. Test re-runs on 980447 worked as expected. Please shout if anything is broken!

Awesome! I just checked this on another open patch to see for myself. Thanks for doing this!

gerritbot added a comment.Jan 4 2024, 10:19 AM

Change 980393 merged by jenkins-bot:

[integration/config@master] jjb: Drop branchdeploy-codex-node16-npm-docker, no longer used

https://gerrit.wikimedia.org/r/980393

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2024, 10:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL