Page MenuHomePhabricator

Xtools does not recognize class=FL in WikiProject banner shell
Closed, ResolvedPublic

Description

Pages which use the class parameter in the WikiProject banner shell (instead of specifying it for each WikiProject tag) and use a value of "FL" are showing up on Xtools with an assessment of "Unknown". I moved the class parameter to the banner shell on several other articles to test and I found that featured lists were the only one coming up as unknown when class was implemented in the banner shell.

Examples of pages showing up as unknown with the FL assessment in the banner shell: "List of awards and honours received by Angela Merkel", "List of National Football League annual passing touchdowns leaders", and "List of National Football League annual rushing touchdowns leaders".

XTools version: 3.18.6-bfa68078

Event Timeline

MusikAnimal subscribed.

@Hey_man_im_josh Checking Special:PageAssessments on the wiki, I see the examples you give don't have a "Class" value for WikiProject Lists:

https://en.wikipedia.org/wiki/Special:PageAssessments?project=&namespace=0&page_title=List+of+awards+and+honours+received+by+Angela+Merkel

When I examine the wikitext of the talk page, I see:

{{WikiProject banner shell |class=FL|1=
{{WikiProject Lists|importance=Low}}
{{WikiProject National Football League |importance=mid}}
{{WikiProject American football |importance=Mid}}
}}

So it would seem there is a coding error either in Template:WikiProject banner shell or in Template:WikiProject Lists where the assessment isn't getting store for WikiProject Lists. I would suggest contacting authors of those templates and making sure the correct value gets passed to {{#assessment}} parser function.

However, XTools is supposed to show the first non-"Unknown" assessment, so there's still a bug here. Roughly related to T247792.

@Hey_man_im_josh Checking Special:PageAssessments on the wiki, I see the examples you give don't have a "Class" value for WikiProject Lists:

https://en.wikipedia.org/wiki/Special:PageAssessments?project=&namespace=0&page_title=List+of+awards+and+honours+received+by+Angela+Merkel

When I examine the wikitext of the talk page, I see:

{{WikiProject banner shell |class=FL|1=
{{WikiProject Lists|importance=Low}}
{{WikiProject National Football League |importance=mid}}
{{WikiProject American football |importance=Mid}}
}}

So it would seem there is a coding error either in Template:WikiProject banner shell or in Template:WikiProject Lists where the assessment isn't getting store for WikiProject Lists. I would suggest contacting authors of those templates and making sure the correct value gets passed to {{#assessment}} parser function.

However, XTools is supposed to show the first non-"Unknown" assessment, so there's still a bug here. Roughly related to T247792.

@MusikAnimal: Looks like it does have to do with the Template:WikiProject Lists. I removed that template from the talk page of List of awards and honours received by Angela Merkel and now Xtools is properly reflecting that the page is a featured list.

Note that this has been resolved on-wiki. It was an issue with the {{WikiProject Lists}} template not having opted into inheriting permissions from the {{Wikiproject banner shell}}. There has since been a fix coded to inherit the permission when it matches one on the WikiProject's assessment scale, even if said WikiProject has not opted in.