Hi! I was wondering why some items show as "unknown" through xtools, when they are correctly tagged with the class/importance.
For instance https://xtools.wmflabs.org/topedits/en.wikipedia.org/Lee%20Vilenski/0 shows the article https://en.wikipedia.org/wiki/2019_Champion_of_Champions as being "unknown", despite being an FA. Other examples include [[Virtual Pool]] and [[Jimmy White's 2: Cueball]].
Any input on why this happens would be gratefully appreciated.
This might be a separate issue, but it appears that XTools is case-sensitive when it comes to article assessments - see for example https://xtools.wmflabs.org/topedits/en.wikipedia.org/David%20Eppstein/0 where you can see that "Start" and "Stub" are considered valid classes, whereas "start" and "stub" are not, despite the fact that the WikiProject templates don't care. You can also see this on the article info page: https://xtools.wmflabs.org/articleinfo/en.wikipedia.org/Smooth_number#assessments https://en.wikipedia.org/w/index.php?title=Talk:Smooth_number&action=edit
I'm assuming all of those examples are using {{maths rating}}. That template is not extending {{WPBannerMeta}} as it should be, which would normalize the values. I reported this on the talk page back in October 2018: https://en.wikipedia.org/wiki/Template_talk:Maths_rating#Corrupt_page_assessments_data. XTools reads directly from the PageAssessments database. Better to clean up the data there than have consumers of that data do the cleaning.
As for the bug reported with this task, it seems all the examples given now show the correct assessment. Perhaps fixes were made to the WikiProject templates there too, similar to what needs to be done to {{maths rating}}?
Pinging @LeeVilenski to confirm that everything looks correct now.
Hi @MusikAnimal, thanks for taking a look at this - I did resolve this with removing (or hiding such as this edit [https://en.wikipedia.org/w/index.php?title=Talk%3AJimmy_White%27s_2%3A_Cueball&type=revision&diff=959452366&oldid=959450281]) the GOCE template on these items. I suggest there is an issue with this that template, and the lack of inate classing causes a conflict even if you add the parameter. Not sure if this needs further investigation of that template.
I've fixed the {{math rating}} template to capitalize the class and importance ratings and it seems to have fixed the problems for the maths articles.
This does point to a bug with XTool's case sensitivity.
It's worth noting that I've found this error to be quite reliant on the GOCE tag, as it seems to overwrite the assessment ratings for the individual wikiprojects. There are some others that seem to also fit the bill, that just give wikiproject-esque templates without a rating.
Something like [https://en.wikipedia.org/w/index.php?title=Talk:Pin_billiards&action=edit Pin Billiards] is listed as "DAB", which wikipedia reads ok, but Xtools doesn't.
I've cleared out most of the issues on my account, but GOCE has been the major thing to fix.
https://xtools.wmflabs.org/topedits/en.wikipedia.org/1234qwer1234qwer4/10 shows full "Unknown" assessment despite most of the pages having Template-class set on the talk page.
This does point to a bug with XTool's case sensitivity.
The issue with case sensitivity also exists in the database itself, which is what XTools fetches from. It's for this reason that I don't think any workarounds should be built in XTools, because other clients that read from the database are going to have the same problem. The templates should do the normalization.
I'll still keep this open though because there are situations where there are both unknown and known assessments, but we still sometimes show "Unknown" because that's the first one that is returned in the database. So the solution is to grab the first non-"Unknown" value. Doing this may or may not have a performance impact. I'll try to investigate soon.