Page MenuHomePhabricator

Don't allow files to be used through codexComponents if they aren't marked as entry points in the manifest
Closed, ResolvedPublic2 Estimated Story Points

Description

The manifest.json files marks files that are meant to be used directly with entry: true. Files without this marker are called "chunks", they just exist to house code that is reused between different entry point files, and their existence is not stable (if the import relationships in the code change, those files could be renamed or deleted in a future release without warning).

For this reason, CodexModule should throw an error if something is listed in codexComponents that does not correspond to an entry point file.

(This will require fixing T353190 first: right now too many things that we'd like to be able to use in codexComponents are not yet designated as entry points.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 991393 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] CodexModule: Throw exception for non-entry points

https://gerrit.wikimedia.org/r/991393

Change 991393 merged by jenkins-bot:

[mediawiki/core@master] CodexModule: Throw exception for non-entry points

https://gerrit.wikimedia.org/r/991393

Change 991659 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] CodexModuleTest: Add test for exception when requesting chunks

https://gerrit.wikimedia.org/r/991659

Change 993460 had a related patch set uploaded (by Tyhopp; author: Catrope):

[mediawiki/core@master] CodexModuleTest: Add test for exception when requesting chunks

https://gerrit.wikimedia.org/r/993460

Change 993460 abandoned by Tyhopp:

[mediawiki/core@master] CodexModuleTest: Add test for exception when requesting chunks

Reason:

This was created by accident when attempting to rebase on 991659

https://gerrit.wikimedia.org/r/993460

Change 991659 merged by jenkins-bot:

[mediawiki/core@master] CodexModuleTest: Add test for exception when requesting chunks

https://gerrit.wikimedia.org/r/991659