Page MenuHomePhabricator
Create Task
Maniphest T353269

Extract ref validation into a separate class
Closed, ResolvedPublic
Actions

Description

Encapsulation makes it clear that validation has no side-effects, improves testing, and declutters a superclass.

Implementation

Details

SubjectRepoBranchLines +/-
Avoid the term "book referencing" in a few placesmediawiki/extensions/Citemaster+12 -5
More simple and consistent @covers and @license tagsmediawiki/extensions/Citemaster+27 -101
Move Validator tests to a separate classmediawiki/extensions/Citemaster+289 -277
Extract validation to a separate classmediawiki/extensions/Citemaster+175 -152
Use short fn() syntax in tests where it makes sensemediawiki/extensions/Citemaster+18 -47
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT353227 [Epic] Cleanups in Cite Extension
 ResolvedthiemowmdeT353269 Extract ref validation into a separate class

Event Timeline

awight created this task.Dec 12 2023, 3:04 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-12-06 board.
gerritbot added a comment.Dec 12 2023, 6:10 PM

Change 982367 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract validation to a separate class

https://gerrit.wikimedia.org/r/982367

gerritbot added a project: Patch-For-Review.Dec 12 2023, 6:10 PM

Change 982368 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move Validator tests to a separate class

https://gerrit.wikimedia.org/r/982368

gerritbot added a comment.Dec 12 2023, 9:06 PM

Change 982367 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract validation to a separate class

https://gerrit.wikimedia.org/r/982367

gerritbot added a comment.Dec 14 2023, 7:43 AM

Change 982367 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract validation to a separate class

https://gerrit.wikimedia.org/r/982367

thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-12-06 board.Dec 14 2023, 8:04 AM
gerritbot added a comment.Dec 14 2023, 8:05 AM

Change 983130 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use short fn() syntax in tests where it makes sense

https://gerrit.wikimedia.org/r/983130

gerritbot added a comment.Dec 14 2023, 12:52 PM

Change 983130 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use short fn() syntax in tests where it makes sense

https://gerrit.wikimedia.org/r/983130

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 14 2023, 1:00 PM
gerritbot added a comment.Dec 14 2023, 2:18 PM

Change 982367 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extract validation to a separate class

https://gerrit.wikimedia.org/r/982367

gerritbot added a comment.Dec 14 2023, 4:10 PM

Change 982368 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move Validator tests to a separate class

https://gerrit.wikimedia.org/r/982368

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2023-12-06 board.Dec 15 2023, 10:54 AM
WMDE-Fisch subscribed.

Seems done to me.

gerritbot added a comment.Dec 15 2023, 11:23 AM

Change 983378 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] More simple and consistent @covers and @license tags

https://gerrit.wikimedia.org/r/983378

gerritbot added a comment.Dec 15 2023, 1:10 PM

Change 983378 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] More simple and consistent @covers and @license tags

https://gerrit.wikimedia.org/r/983378

gerritbot added a comment.Dec 15 2023, 2:49 PM

Change 983427 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Avoid the term "book referencing" in a few places

https://gerrit.wikimedia.org/r/983427

gerritbot added a comment.Dec 18 2023, 11:58 AM

Change 983427 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Avoid the term "book referencing" in a few places

https://gerrit.wikimedia.org/r/983427

thiemowmde closed this task as Resolved.Dec 20 2023, 10:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL