new Impact module: info messages display $2 for users with zero edits
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Dec 14 2023, 2:33 AM

Description

Steps to replicate the issue (include links if applicable):

As a user with less than 1,000 edits, go to Special:Homepage
Click on the info icon to see the text.

What happens?:

The text displays $2 for the edit count instead of 1,000

Screen Shot 2023-12-13 at 6.13.56 PM.png (1×1 px, 288 KB)

Screen Shot 2023-12-13 at 6.12.17 PM.png (1×1 px, 202 KB)

What should have happened instead?:
The text should always display the number 1,000 since it's an explanation of how the count is performed.

Software version (skip for WMF-hosted wikis like Wikipedia):
The bug is present in wmf.7 and wmf.9.

Details

	Subject	Repo	Branch	Lines +/-
	User impact: pass second argument for tooltip info	mediawiki/extensions/GrowthExperiments	master	+60 -9

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Dec 14 2023, 2:33 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 14 2023, 2:33 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Etonkovidova renamed this task from new Impact module: info messages display $2 for zero edits to new Impact module: info messages display $2 for users with zero edits.Dec 14 2023, 2:33 AM

The issue appears to be at https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/master/modules/ext.growthExperiments.Homepage.NewImpact/components/NoEditsDisplay.vue#36; the message (growthexperiments-homepage-impact-scores-thanks-info-text) is missing its second argument.

Etonkovidova moved this task from Inbox to Triaged on the Growth-Team board.Jan 5 2024, 7:01 PM

Sgs claimed this task.Jan 9 2024, 5:35 PM

Sgs edited projects, added Growth-Team (Sprint 6 (Growth Team)); removed Growth-Team.

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 6 (Growth Team)) board.Jan 9 2024, 5:40 PM

Change 989226 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: pass second argument for tooltip info

https://gerrit.wikimedia.org/r/989226

gerritbot added a project: Patch-For-Review.Jan 9 2024, 6:48 PM

In T353410#9405463, @Vahurzpu wrote:

The issue appears to be at https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/master/modules/ext.growthExperiments.Homepage.NewImpact/components/NoEditsDisplay.vue#36; the message (growthexperiments-homepage-impact-scores-thanks-info-text) is missing its second argument.

You are right, I think the other scorecard (best streak) also suffers from the same problem. It should be solved after 989226 is merged and deployed. Thanks for reporting!

Urbanecm_WMF edited projects, added GrowthExperiments-Homepage, Growth-Positive-Reinforcement; removed GrowthExperiments.Jan 10 2024, 3:05 PM

Change 989226 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: pass second argument for tooltip info

https://gerrit.wikimedia.org/r/989226

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 10 2024, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2024, 8:30 PM

Urbanecm_WMF triaged this task as Medium priority.Jan 11 2024, 11:47 AM

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 6 (Growth Team)) board.

Etonkovidova closed this task as Resolved.Jan 16 2024, 10:08 PM

	F41599852: Screen Shot 2023-12-13 at 6.12.17 PM.png
	Dec 14 2023, 2:33 AM

	F41599850: Screen Shot 2023-12-13 at 6.13.56 PM.png
	Dec 14 2023, 2:33 AM

new Impact module: info messages display $2 for users with zero editsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

new Impact module: info messages display $2 for users with zero edits
Closed, ResolvedPublicBUG REPORT
Actions