Page MenuHomePhabricator
Create Task
Maniphest T353793

NewPP limit report no longer includes units and limits
Closed, ResolvedPublic
Actions

Description

(reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#NewPP_limit_report_change)

NewPP limit report no longer includes units and limits, for example on https://en.wikipedia.org/wiki/Golden_ratio:

CPU time usage: 2.016
Real time usage: 2.471
Preprocessor visited node count: 14645
Post‐expand include size: 370602

Expected rendering, copied from an old integration test https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/3a2e10588bae3a4e0a60bb1be20e72d245308c56/tests/cases/ar-nbsp-timezone-oldparser/ar-nbsp-timezone-oldparser.html:

CPU time usage: 0.112 seconds
Real time usage: 0.177 seconds
Preprocessor visited node count: 599/1000000
Post‐expand include size: 10641/2097152 bytes

Details

SubjectRepoBranchLines +/-
Fix showing units and limits in NewPP limit reportmediawiki/corewmf/1.42.0-wmf.10+1 -1
Fix showing units and limits in NewPP limit reportmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Dec 20 2023, 11:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2023, 11:19 AM
matmarex added a comment.Dec 20 2023, 11:33 AM

This is caused by rMWa3f51c732d5d: Refactor DefaultOutputTransform into a pipeline of transforms.

In addition to moving the code around, that commit also changed some uses of wfMessage to Message::newFromSpecifier. However, these functions are not the same – when given an array, Message::newFromSpecifier treats it as a message key and parameters, while wfMessage treats it as a message key and fallback message keys: https://gerrit.wikimedia.org/g/mediawiki/core/+/486c4075871625c4be752555ccddac22d2caf0d7/includes/GlobalFunctions.php#901

Specifically, the problem is in this line:
Old: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/a3f51c732d5d2d24ac205c0855df1e78abafb421~1/includes/ParserOutputTransform/DefaultOutputTransform.php#409
$valueMsg = wfMessage( [ "$key-value-text", "$key-value" ] )
New: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/a3f51c732d5d2d24ac205c0855df1e78abafb421/includes/OutputTransform/Stages/RenderDebugInfo.php#79
$valueMsg = Message::newFromSpecifier( [ "$key-value-text", "$key-value" ] )
As a result, localisation messages such as limitreport-postexpandincludesize-value are not used.

It should use Message::newFallbackSequence instead.

Novem_Linguae subscribed.Dec 20 2023, 12:24 PM
Reedy added a project: Regression.Dec 20 2023, 2:38 PM
NightWolf1223 subscribed.Dec 20 2023, 3:44 PM
matmarex claimed this task.Dec 21 2023, 10:40 AM
gerritbot added a comment.Dec 21 2023, 10:43 AM

Change 984809 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Fix showing units and limits in NewPP limit report

https://gerrit.wikimedia.org/r/984809

gerritbot added a project: Patch-For-Review.Dec 21 2023, 10:43 AM
gerritbot added a comment.Dec 21 2023, 11:12 AM

Change 984809 merged by jenkins-bot:

[mediawiki/core@master] Fix showing units and limits in NewPP limit report

https://gerrit.wikimedia.org/r/984809

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2023, 11:30 AM
gerritbot added a comment.Dec 21 2023, 11:53 AM

Change 984501 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.42.0-wmf.10] Fix showing units and limits in NewPP limit report

https://gerrit.wikimedia.org/r/984501

gerritbot added a project: Patch-For-Review.Dec 21 2023, 11:53 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 21 2023, 12:00 PM
gerritbot added a comment.Dec 21 2023, 2:42 PM

Change 984501 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.10] Fix showing units and limits in NewPP limit report

https://gerrit.wikimedia.org/r/984501

Stashbot added a comment.Dec 21 2023, 2:43 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-21T14:43:17Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:984501|Fix showing units and limits in NewPP limit report (T353793)]]

Stashbot added a comment.Dec 21 2023, 2:44 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-21T14:44:57Z] <lucaswerkmeister-wmde@deploy2002> matmarex and lucaswerkmeister-wmde: Backport for [[gerrit:984501|Fix showing units and limits in NewPP limit report (T353793)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 21 2023, 2:52 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-21T14:52:45Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:984501|Fix showing units and limits in NewPP limit report (T353793)]] (duration: 09m 27s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 2023-12-19); removed MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 21 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 21 2023, 3:30 PM
matmarex closed this task as Resolved.Dec 21 2023, 3:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL