Page MenuHomePhabricator

Edited pages aggregate endpoint does not filter on activity levels
Closed, ResolvedPublicBUG REPORT

Description

edited_pages_aggregate_data.go file in the ProcessEditedPagesAggregateQuery function:

activityLevel was not considered when building the parameters map to pass later to the ProcessTimeseriesQuery function. Just the following code must be added when populating the query parameters:
var parameters = DruidQueryParams{

. . .
ActivityLevel:         activityLevel,
. . .

}

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 984802 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[generated-data-platform/aqs/edit-analytics@main] Passing activity-level value to the query for edited_pages_aggregate

https://gerrit.wikimedia.org/r/984802

Change 984802 merged by jenkins-bot:

[generated-data-platform/aqs/edit-analytics@main] Passing activity-level value to the query for edited_pages_aggregate

https://gerrit.wikimedia.org/r/984802

I took the opportunity to add a new test case to the QA test suite to be able to test the specific activity-levels for this endpoint (https://gitlab.wikimedia.org/repos/generated-data-platform/aqs/aqs_tests/-/merge_requests/31). At this moment we were testing always using 'all-activity-levels' value that is the default value that the query uses when no parameter is passed. It worked fine for that case but not for the specific ones (1..4, 5..24, 25..99 and 100..)

Another bug in this service was raised (T354074: Wikistats - incorrect number of content articles for Latvian Wikipedia ) and it's already deployed to production, so this fix is already deployed as well. Anyway, the MR for the QA test suite is still pending review

In the end we have decided to split this ticket into two:

That's why we can already consider this ticket as Done and keep working on the QA new test case with the new one.