Page MenuHomePhabricator

Show a better error page when returning an HTTP 429, not the "Our servers are currently under maintenance" one for 5xxs
Open, MediumPublic

Description

Per a wikitech-l report, the "Our servers are currently under maintenance or experiencing a technical problem." error page is shown when the appserver returns a 429. This seems wrong, this error page is for 5xx errors. On a 429 we should just tell the user to lay off.

Event Timeline

Vgutierrez triaged this task as Medium priority.Jan 10 2024, 2:20 PM
Vgutierrez moved this task from Backlog to Ready for work on the Traffic board.
Jdforrester-WMF renamed this task from "Our servers are currently under maintenance" page shown on HTTP 429 to Show a better error page when returning an HTTP 429, not the "Our servers are currently under maintenance" one for 5xxs.Jan 10 2024, 4:42 PM
Jdforrester-WMF subscribed.

Admittedly I’m inexperienced here (and so may well be missing something), but in T354858, I received 429 errors that do actually seem to be as a result of a technical problem (rather than the same client repeatedly making requests).

@A_smart_kitten usually what happens is that the first few users get a HTTP 500, then the throttling logic detects that users are repeatedly requesting thumbnailing (instead of fetching a thumbnail from Swift) and starts blocking those requests. So it's true that for thumbnails 429 usually means there's an error, but that specific request doesn't trigger the error, and so its details are not particularly useful for debugging.