Discarding changes in a section discards edit recovery data for the whole page
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 12 2024, 2:28 PM

Description

What is the problem?

I find after I "Show preview" or "Show changes" for a section edit, if I then do "Discard changes" it discards for the whole page (and in some cases the section as well).

Originally raised in T352028#9455995.

Steps to reproduce problem

Go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Conflict-title-0.650954540390162-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&action=edit and make an edit (don't save)
Go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Conflict-title-0.650954540390162-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&action=edit&section=1 and make an edit (don't save)
Reload the page
Click "Discard changes" in the popup
Inspect indexeddb data on the browser. The data for the whole page will have been deleted, but the section data might still be there. If you then trigger an ER save (e.g. by switching tabs) the section data will also be cleared.

Environment

Browser: Firefox 115.
Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.42.0-alpha (cab3f6e) 10:39, 12 January 2024.
Editor: WikiEditor 0.5.4 (cd6b88e) 07:33, 10 January 2024.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T354948 here

Details

	Subject	Repo	Branch	Lines +/-
	Edit Recovery: discard section data	mediawiki/core	master	+4 -6

Customize query in gerrit

Related Objects

Mentioned In: T352028: Recovery data cleared for whole page when section is saved
Mentioned Here: rMW01a6c18dc3a7: Merge "Redefine services before ::newSpecialPage in FormSpecialPageTestCase"
T342721: Show toast notification when restoring edit data
rMW67f80e68bf55: Merge "Update jsdoc-wmf-theme from 0.0.13 to 1.0.0"
rEWEDcd6b88ed23f0: Localisation updates from https://translatewiki.net.
rMWcab3f6e305ec: Merge "Installer codex followup"
T352028: Recovery data cleared for whole page when section is saved

Event Timeline

dom_walden created this task.Jan 12 2024, 2:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2024, 2:28 PM

dom_walden renamed this task from Discarding changes in a section discards changes for the whole section to Discarding changes in a section discards edit recovery data for the whole page.Jan 12 2024, 2:28 PM

dom_walden updated the task description. (Show Details)

dom_walden mentioned this in T352028: Recovery data cleared for whole page when section is saved.

MusikAnimal moved this task from New & TBD Tickets to Up Next (June 3-21) on the Community-Tech board.Jan 17 2024, 3:14 PM

Samwilson moved this task from Backlog to Ready on the Edit Recovery board.Mar 19 2024, 4:45 AM

JWheeler-WMF triaged this task as High priority.Apr 2 2024, 2:20 PM

Samwilson edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Apr 3 2024, 10:47 AM

JWheeler-WMF moved this task from Ready to MVP Scope on the Edit Recovery board.Apr 15 2024, 2:30 PM

(fyi; can no longer replicate this behaviour)

This issue has been fixed as part of other work around section-saving.

@Samwilson As you mentioned earlier, this is by design. The idea is that when you click on "Show Preview" or "Show Changes", you know what you're doing and the contents are all that you're currently working with. The recovery process should only happen when you start editing. I did come across another error as seen below though.

Status: ❌FAIL
Environment: Beta: 1.43.0-alpha (67f80e6
OS: macOS Sonoma 14.4.1
Browser: Chrome 123
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_Page_123&action=edit
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_Page_123&action=edit&section=1

❌AC1: https://phabricator.wikimedia.org/T354948 - I did an edit on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_Page_123&action=edit with "DARK". Then I did an edit on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_Page_123&action=edit&section=1 with "LIGHT". I did discard changes to remove "Light" but as you see in the video, it also removed "Dark" from the IndexDB.

GMikesell-WMF updated the task description. (Show Details)Apr 16 2024, 10:12 PM

GMikesell-WMF moved this task from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.

aaah... I feel a bit silly. It would appear that we've never been able to discard data for a section: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/965051/11/resources/src/mediawiki.editRecovery/edit.js#92

I guess we didn't think about it for T342721: Show toast notification when restoring edit data.

Fixing now!

Change #1020440 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: discard section data

https://gerrit.wikimedia.org/r/1020440

gerritbot added a project: Patch-For-Review.Apr 17 2024, 2:46 AM

Change #1020440 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: discard section data

https://gerrit.wikimedia.org/r/1020440

Discarding for sections should be working correctly now.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 18 2024, 1:00 AM

@Samwilson IndexDB is now working correctly with sections. I will move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.43.0-alpha (01a6c18)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 124, Safari 17.3
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_Page_123&action=edit
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_Page_123&action=edit&section=1

✅AC1: https://phabricator.wikimedia.org/T354948

Chrome-Vector 2022

Firefox	Safari

Vector 2010	Minerva	Monobook	Timeless

GMikesell-WMF updated the task description. (Show Details)Apr 18 2024, 8:35 PM

GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:38 PM

JWheeler-WMF closed this task as Resolved.May 22 2024, 2:13 PM

JWheeler-WMF claimed this task.

	F47049729: T354948_ER_Sections_IndexDB.webm
	Apr 16 2024, 10:09 PM

Discarding changes in a section discards edit recovery data for the whole pageClosed, ResolvedPublicBUG REPORTActions