Write to the user_is_temp column
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Jan 16 2024, 6:16 PM

Project Tags

Referenced Files

	F41729254: 2024-01-29_11-56-49.png
	Jan 29 2024, 8:03 PM

	F41729252: 2024-01-29_11-57-10.png
	Jan 29 2024, 8:03 PM

Subscribers

Description

The user_is_temp column was added to WMF wikis in T336886: Add user_is_temp field to the user table in MediaWiki core and was added to mediawiki/core in T333223: Adding user_is_temp to the user table.

This task is about writing to this column for code that creates temporary accounts so that the user_is_temp column is populated with the correct values. Currently, the code in charge of creating temporary accounts does not cause this column to be written to.

Acceptance criteria

Start writing to user_is_temp in the user table with the value 1 when the user is a temporary account

QA Results - Visual Studio

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T355175 here

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Set user.user_is_temp when creating a temporary user	Tchanders	mediawiki/core	master	+27 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T333223 Adding user_is_temp to the user table
Resolved	Dreamy_Jazz	T355181 Populate user_is_temp column for existing temporary accounts
Resolved	Tchanders	T355175 Write to the user_is_temp column

Event Timeline

Dreamy_Jazz created this task.Jan 16 2024, 6:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2024, 6:16 PM

Dreamy_Jazz added a subscriber: Tchanders.Jan 16 2024, 6:16 PM

Dreamy_Jazz added a parent task: T333223: Adding user_is_temp to the user table.Jan 16 2024, 6:54 PM

Dreamy_Jazz added a parent task: T355181: Populate user_is_temp column for existing temporary accounts.Jan 16 2024, 6:56 PM

I'm sure there is patch for this already by Thalia and has a -2 or something like that.

In T355175#9463546, @Ladsgroup wrote:

I'm sure there is patch for this already by Thalia and has a -2 or something like that.

yup, https://gerrit.wikimedia.org/r/c/mediawiki/core/+/918514/

Change 918514 had a related patch set uploaded (by Dreamy Jazz; author: Tchanders):

[mediawiki/core@master] Set user.user_is_temp when creating a temporary user

https://gerrit.wikimedia.org/r/918514

gerritbot added a project: Patch-For-Review.Jan 17 2024, 10:44 AM

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)).Jan 17 2024, 10:53 AM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)) board.

Dreamy_Jazz assigned this task to Tchanders.Jan 17 2024, 11:06 AM

kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)) board.Jan 22 2024, 8:35 AM

Change 918514 merged by jenkins-bot:

[mediawiki/core@master] Set user.user_is_temp when creating a temporary user

https://gerrit.wikimedia.org/r/918514

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 22 2024, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 9:30 AM

Dreamy_Jazz edited projects, added: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)); removed: Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)).Jan 29 2024, 1:08 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Jan 29 2024, 1:30 PM

@Tchanders The user_is_temp in the user table shows a value of "1" and new created user as "0" as seen in the screenshots below. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Visual Studio
OS: macOS Sonoma 14.2.1
Browser: Chrome 120
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
N/A