Page MenuHomePhabricator

SX: Navigation among sections doesn't work properly in "Compare contents" step
Closed, ResolvedPublicBUG REPORT

Description

Inside the "Compare contents" step, the user should be able to navigate among all sections, starting from missing sections. For this reason, there are two arrow buttons to navigate to the next/previous section.

However, clicking on these buttons do not navigate the user to next/previous section, but navigate to a randomly selected section as demonstrated in the screencast (from el production wiki) below:

Event Timeline

ngkountas changed the task status from Open to In Progress.Jan 24 2024, 2:25 PM
ngkountas claimed this task.
ngkountas triaged this task as Medium priority.
ngkountas added a project: SectionTranslation.

Change 992102 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX Compare contents step: Fix section navigation

https://gerrit.wikimedia.org/r/992102

Change 992102 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX Compare contents step: Fix section navigation

https://gerrit.wikimedia.org/r/992102

Change 1004124 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240216

https://gerrit.wikimedia.org/r/1004124

Change 1004124 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240216

https://gerrit.wikimedia.org/r/1004124

Test status: QA PASS

Able to navigate to the section and back
Able to navigate throught the section in order of appearance

Pginer-WMF subscribed.

Great! This (and maybe other related fixes) are resolving the issues captured in T300368: Some buttons no longer work in the step to Compare the Contents in Section Translation.

There is an unintended change of behaviour: the proposed design was making previous arrow disabled on the initial section of the sequence and the next arrow to be disabled at the last. The current behaviour allows users to cycle. This is not a major difference and we can live with the current behaviour. Just noting it for future reference.

Noted! Sounds like an easy fix, maybe we can opportunistically fix that at some point.