Page MenuHomePhabricator
Create Task
Maniphest T355842

Remove themeStyles support from CodexModule
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We would like to remove support for the themeStyles feature in CodexModule, since it's duplicative of the manifest selection code in CodexModule. Right now, adding a new theme requires adding it in two places: in CodexModule's manifest selection code (which powers modules that use code splitting), and in the themeStyles property of the module definitions of things that still use it (the full-library @wikimedia/codex module, and VueTest). Removing themeStyles would centralize the theme selection in one place (CodexModule::getManifestFile()).

In order to remove themeStyles, we first need to migrate all uses of it.

Related Objects
Search...

Event Timeline

Catrope created this task.Jan 25 2024, 1:04 AM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptJan 25 2024, 1:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope added subtasks: T355841: Remove use of themeStyles in VueTest, T350058: Code splitting: migrate existing library modules to new system, T355840: Code splitting: use CodexModule for the full library modules (@wikimedia/codex and codex-styles).Jan 25 2024, 1:05 AM
Catrope mentioned this in T350058: Code splitting: migrate existing library modules to new system.
Catrope added a parent task: T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule.
Catrope closed subtask T350058: Code splitting: migrate existing library modules to new system as Resolved.
CCiufo-WMF triaged this task as Medium priority.Jan 25 2024, 4:01 PM
CCiufo-WMF moved this task from Inbox to Up Next on the Design-System-Team board.
lwatson mentioned this in T349423: [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule.Jan 28 2024, 8:49 PM
CCiufo-WMF moved this task from Inbox to Infrastructure on the Codex board.Feb 2 2024, 7:48 PM
CCiufo-WMF set the point value for this task to 2.Feb 5 2024, 6:45 PM
CCiufo-WMF moved this task from Up Next to DST-Sprint-16 (2024-02-05 to 2024-02-16) on the Design-System-Team board.
CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)); removed Design-System-Team.
Catrope updated the task description. (Show Details)Feb 5 2024, 6:47 PM
egardner closed subtask T355841: Remove use of themeStyles in VueTest as Declined.Feb 13 2024, 9:27 PM
lwatson changed the status of subtask T355840: Code splitting: use CodexModule for the full library modules (@wikimedia/codex and codex-styles) from Open to In Progress.Feb 14 2024, 5:10 PM
CCiufo-WMF moved this task from DST-Sprint-16 (2024-02-05 to 2024-02-16) to Up Next on the Design-System-Team board.Feb 20 2024, 5:55 PM
CCiufo-WMF edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-16 (2024-02-05 to 2024-02-16)).
Catrope reopened subtask T355841: Remove use of themeStyles in VueTest as Open.Feb 20 2024, 5:56 PM
Catrope mentioned this in T355841: Remove use of themeStyles in VueTest.
Catrope closed subtask T355840: Code splitting: use CodexModule for the full library modules (@wikimedia/codex and codex-styles) as Resolved.Feb 23 2024, 2:05 AM
Catrope closed this task as Resolved.Feb 23 2024, 6:12 PM
Catrope claimed this task.

This was accidentally done as part of the change for T355842. This will break VueTest because of T355841, which may have broken Pixel -- we'll have to address that.

Catrope added a comment.Feb 23 2024, 7:02 PM

Looks like it's not that bad: there are no errors, the themeStyles VueTest specifies just aren't being applied. This breaks the styles for most components (see https://en.wikipedia.beta.wmflabs.org/wiki/Special:VueTest/codex and scroll to Card or Checkbox; the Button styles are still there because the Vector search pulls them in), and as a consequence there's a lot of red on https://pixel.wmcloud.org/reports/codex/index.html , but we weren't actively using those anyway.

Catrope closed subtask T355841: Remove use of themeStyles in VueTest as Declined.Feb 29 2024, 8:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL