Fix no-thank-you reason default
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Eileenmcnaughton
	Feb 1 2024, 4:16 AM

Description

The code prefilling 'no thank you reason' is not working properly. I think this was already broken for the last few months & the upgrade made me spot it (based on when the CiviCRM code actually changed)

However the question I have for @NNichols & @MDemosWMF is whether I should fix it or remove it - I feel like the business requirement has changed.

What the code should do is fill in the No Thank You Reason when a user enters a new contribution with either 'Manually entered' or 'Stock', if the financial type is Stock. Entering this prevents an automated thank you from being sent.

Details

	Subject	Repo	Branch	Lines +/-
	Remove code that sets UI default for no thank you	wikimedia/fundraising/crm	master	+0 -101

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Dwisehaupt	T337581 FR-Tech FY2324Q3 maintenance window
Resolved	Eileenmcnaughton	T354706 Upgrade CiviCRM to 5.70-rc
Resolved	Eileenmcnaughton	T356366 Fix no-thank-you reason default
Resolved	Eileenmcnaughton	T356433 Remove engage UI code

Event Timeline

Eileenmcnaughton created this task.Feb 1 2024, 4:16 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 1 2024, 4:16 AM

Change 994872 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix no-thank you reason code

https://gerrit.wikimedia.org/r/994872

gerritbot added a project: Patch-For-Review.Feb 1 2024, 4:17 AM

Major gifts recently changed their rules to have no threshold for auto TY's from Civi so I'm not sure this is needed anymore. Basically everyone gets an auto thank you if they have an email address. The only gifts we don't send TYs to are matching gifts which all come in on imports (matching check, matching EFT, and Benevity).

Eileenmcnaughton moved this task from Backlog to Ready for Review on the Fundraising Sprint: brb() board.Feb 1 2024, 7:13 PM

Change 994872 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove code that sets UI default for no thank you

https://gerrit.wikimedia.org/r/994872

Eileenmcnaughton moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: brb() board.Feb 1 2024, 10:12 PM

AKanji-WMF moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Feb 2 2024, 9:14 PM

Jgreen moved this task from Triage to Watching on the fundraising-tech-ops board.Feb 2 2024, 9:16 PM

Eileenmcnaughton moved this task from Pending Deployment to Done on the Fundraising Sprint: brb() board.Feb 5 2024, 10:27 PM

XenoRyet closed this task as Resolved.Feb 12 2024, 8:21 PM

XenoRyet set Final Story Points to 2.

XenoRyet closed subtask T356433: Remove engage UI code as Resolved.

Dwisehaupt moved this task from Watching to Done on the fundraising-tech-ops board.Feb 27 2024, 1:17 AM