Page MenuHomePhabricator

Remove <graph> tags with less-than signs from Graph extension messages
Closed, ResolvedPublicBUG REPORT

Description

The L10n bot change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Graph/+/995151 had to be manually merged because the message translation included a <graph> tag, which is unrecognized by Jenkins job configuration:

[mediawiki-i18n-check-docker] $ /bin/bash /tmp/jenkins1542011854923282206.sh
+ cd src
++ pwd
+ git config --global --add safe.directory /srv/jenkins/workspace/mediawiki-i18n-check-docker/src
++ mktemp
+ additions=/tmp/tmp.sxNPtYvt86
+ git show FETCH_HEAD -U0
+ grep '^+'
+ contains_disallowed_html /tmp/tmp.sxNPtYvt86
+ cat /tmp/tmp.sxNPtYvt86
+ sed -E -e 's/<\/? ?(abbr|span|br|strong|em|pre|nowiki|charinsert|b|del|code|kbd|p|tt|div|i|big|sup|sub|samp|var|small|h1|h2|h3|h4|u|ol|ul|li|mark|user|page|hr|templatestyles|NDL|math|syntaxhighlight|templatedata|pagelist|bdi|ref|dd|dl)( ((class|title|lang|xml:lang|dir|xmlns|display|alttext)=\\?["'\''][^=<>"'\'']*\\?["'\'']))* ?\/?>//g' -e 's/<!--//g' -e 's/<https?:\/\/[a-zA-Z0-9./-]*>//g'
+ grep '<'
+	"graph-tracking-category-desc": "Síðan innifelur <graph>-merki.",
+	"graph-broken-category-desc": "Síðan innifelur <graph>-merki með ógildri notkun.",
+	"graph-obsolete-category-desc": "Síðan innifelur <graph>-merki sem ætti að uppfæra á útgáfu 5.",
+ echo 'HTML detected. Manual review required'
HTML detected. Manual review required

The easy solution appears to be to replace <code><nowiki><graph></nowiki></code> with &lt;graph&gt;, which was already done in another message.

Event Timeline

Change 995374 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/Graph@master] Replace <graph> with &lt;graph&gt;

https://gerrit.wikimedia.org/r/995374

Change 995374 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] Replace <graph> with &lt;graph&gt;

https://gerrit.wikimedia.org/r/995374

Change 1006079 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/WikimediaMessages@master] Replace <graph> with &lt;graph&gt;

https://gerrit.wikimedia.org/r/1006079

Change 1006079 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Replace <graph> with &lt;graph&gt;

https://gerrit.wikimedia.org/r/1006079