Page MenuHomePhabricator

[Refactor] Decouple reference reuse workflow from internalList
Open, Needs TriagePublic

Description

The MWReferenceSearchWidget shows footnote bodies, these should be pulled from the refnode attribute.

Note that there is some overlap with T336417: Reusing references inside and from a VE image/gallery dialog, but it's best if this task is limited to finding refs in the currently-visible document fragment so that functionality is unchanged, and we can postpone harder decisions about merging across documents until internalList is fully deprecated.

Event Timeline

Change 998442 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Reference reuse workflow decoupled from internalList

https://gerrit.wikimedia.org/r/998442

Change 1005798 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use original ref name instead of parsing internal listKey

https://gerrit.wikimedia.org/r/1005798

Change 1005802 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove confusing, unnecessary .length check on a string

https://gerrit.wikimedia.org/r/1005802

Change 1005810 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use OOUI's native "unselect all" feature

https://gerrit.wikimedia.org/r/1005810

Change 1005818 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Consolidate duplicate "is reference list empty" code paths

https://gerrit.wikimedia.org/r/1005818

Change 1005834 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Make ReferenceSearchWidget code a bit more functional

https://gerrit.wikimedia.org/r/1005834

Change 1005835 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Further delay search index build in ReferenceSearchWidget

https://gerrit.wikimedia.org/r/1005835

Change #1005802 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove confusing, unnecessary .length check on a string

https://gerrit.wikimedia.org/r/1005802