Page MenuHomePhabricator

Gallery node not highlighted after closing gallery dialog
Closed, ResolvedPublic

Description

This works for images, but not Gallery.

Screenshot 2024-02-01 at 15.34.15.png (392×1 px, 34 KB)

Would the expected behaviour be that the gallery is focused if a change is applied to any of the images?
Also what is the expected behaviour if changes are applied to the gallery? Changing the caption for instance.

For consistency, I'd say we have the gallery focused as seen in the screenshot.

Experience:

Screenshot 2024-02-01 at 15.37.05.png (618×1 px, 58 KB)

Expected?:

Screenshot 2024-02-01 at 15.37.14.png (534×1 px, 47 KB)

Note: I am able to navigate with the arrow keys on the keyboard after interacting with the gallery so, I wouldn't say accessibility is broken.

Event Timeline

Change 998825 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] FocusableNode: Try to redraw highlights during setup

https://gerrit.wikimedia.org/r/998825

Change 998825 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] FocusableNode: Try to redraw highlights during setup

https://gerrit.wikimedia.org/r/998825

Change 999066 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (58a24a62c)

https://gerrit.wikimedia.org/r/999066

Change 999066 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (58a24a62c)

https://gerrit.wikimedia.org/r/999066