The used router.php from mediawiki/core was removed in commit 3f9d7166
Description
Details
Related Objects
- Mentioned In
- T218647: Quibble should backup and delete LocalSettings.php
T360443: Quibble --command is no more interactive causing "bash" to show no prompt
T356247: CI test failure due to Git error
T354141: composer stops quibble and requires input - Mentioned Here
- rQUIBBLE6bbe555d1006: release: Quibble 1.7.0
T218647: Quibble should backup and delete LocalSettings.php
T236222: Jenkins console section matching breaks output HTML rendering
T354141: composer stops quibble and requires input
T356247: CI test failure due to Git error
T360443: Quibble --command is no more interactive causing "bash" to show no prompt
rMW3f9d716653fd: maintenance: Remove dev folder
Event Timeline
Change 987183 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[integration/quibble@master] backend: Remove use of mediawiki/core router.php from PhpWebserver
Change 987183 merged by jenkins-bot:
[integration/quibble@master] backend: Remove use of mediawiki/core router.php from PhpWebserver
From my comment in Gerrit:
My concern was whether the Selenium/Qunit tests would work when not using the mediawiki/core router. Turns out they seem to work, so I am not sure why I added the router in the first place, but that might be because the PHP built in server has been enhanced since ~ 2017 and those made the MediaWiki router.php useless nowadays.
Who knows. It seems to work and CI uses Apache anyway. If something is broken we can investigate later.
Thanks for having filed this task and committed to fully cleanup the legacy router!
Change #1014014 had a related patch set uploaded (by Hashar; author: Hashar):
[integration/quibble@master] release: Quibble 1.7.0
Change #1014014 merged by jenkins-bot:
[integration/quibble@master] release: Quibble 1.7.0
Mentioned in SAL (#wikimedia-releng) [2024-03-25T16:05:11Z] <hashar> Tag Quibble 1.7.0 @ 6bbe555d1006e925d5cf760da8f7c6e9374a31bc # T236222 T218647 T360443 T354141 T356247 T357070
Change #1014039 had a related patch set uploaded (by Hashar; author: Hashar):
[integration/config@master] dockerfiles: update Quibble to 1.7.0
Change #1014039 merged by jenkins-bot:
[integration/config@master] dockerfiles: update Quibble to 1.7.0