Page MenuHomePhabricator

Remove use of router.php in PhpWebserver from quibble
Closed, ResolvedPublic

Description

The used router.php from mediawiki/core was removed in commit 3f9d7166

Event Timeline

Change 987183 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[integration/quibble@master] backend: Remove use of mediawiki/core router.php from PhpWebserver

https://gerrit.wikimedia.org/r/987183

Change 987183 merged by jenkins-bot:

[integration/quibble@master] backend: Remove use of mediawiki/core router.php from PhpWebserver

https://gerrit.wikimedia.org/r/987183

From my comment in Gerrit:

My concern was whether the Selenium/Qunit tests would work when not using the mediawiki/core router. Turns out they seem to work, so I am not sure why I added the router in the first place, but that might be because the PHP built in server has been enhanced since ~ 2017 and those made the MediaWiki router.php useless nowadays.

Who knows. It seems to work and CI uses Apache anyway. If something is broken we can investigate later.

Thanks for having filed this task and committed to fully cleanup the legacy router!

Change #1014014 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] release: Quibble 1.7.0

https://gerrit.wikimedia.org/r/1014014

Change #1014014 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.7.0

https://gerrit.wikimedia.org/r/1014014

Change #1014039 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: update Quibble to 1.7.0

https://gerrit.wikimedia.org/r/1014039

Change #1014039 merged by jenkins-bot:

[integration/config@master] dockerfiles: update Quibble to 1.7.0

https://gerrit.wikimedia.org/r/1014039