Echo: Drop droppable rows from user_properties
Open, MediumPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Feb 8 2024, 10:14 PM

Description

In T353225, we enabled conditional defaults for four Echo properties:

echo-subscriptions-web-reverted
echo-subscriptions-web-article-linked
echo-subscriptions-email-mention
echo-subscriptions-email-article-linked

This stopped the influx of new rows to user_properties by Echo's onLocalUserCreated, as those properties default to the new defaults (false for echo-subscriptions-web-reverted, true for the rest) starting 20240208200000.

It should now be possible to drop old rows (from 20130501000000 onwards) by changing the cutoff date and deleting the rows (while keeping in mind the effective user property values should not change for any users). See T353225#9524337 for a previous attempt by @Urbanecm_WMF on testwiki.

Per the following comment by @Ladsgroup, I'm assigning this task to them.

In T353225#9524337, @Ladsgroup wrote:

I will take over the clean up, just please deploy the change ASAP so it stops adding more rows.

Details

	Subject	Repo	Branch	Lines +/-
	Enable echo conditional defaults for loginwiki since 2013	operations/mediawiki-config	master	+5 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Resolved	KStoller-WMF	T347840 [Epic] Q2 FY 2023-24 Growth Maintenance Work
Open	None	T54777 user_properties table bloat
Resolved	Urbanecm_WMF	T354459 [Epic] Support conditional defaults for user properties to help address user_properties table bloat
Open	Ladsgroup	T357072 Echo: Drop droppable rows from user_properties

Event Timeline

Urbanecm_WMF created this task.Feb 8 2024, 10:14 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 8 2024, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF added a parent task: T354459: [Epic] Support conditional defaults for user properties to help address user_properties table bloat.Feb 8 2024, 10:15 PM

Urbanecm_WMF mentioned this in T353225: Echo: Make use of conditional user defaults.Feb 8 2024, 10:17 PM

Urbanecm_WMF mentioned this in T354459: [Epic] Support conditional defaults for user properties to help address user_properties table bloat.Feb 8 2024, 10:20 PM

I will get to it next week.

• Marostegui moved this task from Triage to Ready on the DBA board.Feb 9 2024, 5:46 AM

Urbanecm_WMF mentioned this in T357221: Stop inserting new Echo user_properties rows in the onLocalUserCreated hook.Feb 10 2024, 11:49 PM

Urbanecm_WMF moved this task from Inbox to Triaged on the Growth-Team board.Feb 10 2024, 11:58 PM

Urbanecm_WMF mentioned this in T357223: Write a blog post about conditional user defaults.Feb 11 2024, 12:04 AM

Change 1003408 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Enable echo conditional defaults for loginwiki since 2013

https://gerrit.wikimedia.org/r/1003408

gerritbot added a project: Patch-For-Review.Feb 14 2024, 12:36 PM

Change 1003408 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable echo conditional defaults for loginwiki since 2013

https://gerrit.wikimedia.org/r/1003408

Mentioned in SAL (#wikimedia-operations) [2024-02-14T17:36:05Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:1003408|Enable echo conditional defaults for loginwiki since 2013 (T357072)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-14T17:39:02Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1003408|Enable echo conditional defaults for loginwiki since 2013 (T357072)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-14T17:48:14Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:1003408|Enable echo conditional defaults for loginwiki since 2013 (T357072)]] (duration: 12m 08s)

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 6:30 PM

Sigh for loginwiki it's this:

mysql:research@s3-analytics-replica.eqiad.wmnet [loginwiki]> select up_property, count(*) from user_properties group by up_property order by count(*) desc limit 50;
+------------------------------------------+----------+
| up_property                              | count(*) |
+------------------------------------------+----------+
| wlenhancedfilters-seen-tour              | 20382152 |
| rcenhancedfilters-seen-tour              | 20382130 |

HouseBlaster subscribed.Feb 29 2024, 9:16 PM

Echo: Drop droppable rows from user_propertiesOpen, MediumPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Echo: Drop droppable rows from user_properties
Open, MediumPublic
Actions

Related Objects
Search...