Page MenuHomePhabricator

Cannot reuse VE citations
Closed, ResolvedPublicBUG REPORT

Description

Browser:
FF 102.9.0esr (64-bit) on Windows
Edge 121.0.2277.112 (Official build) (64-bit)
Chrome 121.0.6167.86 (Official Build) (64-bit)

Steps to reproduce:

  1. Open any rowp article with citations in Firefox
  2. Add a new citation, go to the "Reuse citation" tab and click on any existing citation

Expected result: the clicked citation is added again
Actual result: cannot click on citations.

I tried in safe mode, same result.

Initially reported on wiki at https://ro.wikipedia.org/w/index.php?title=Wikipedia:Cafenea&oldid=16100461

Event Timeline

Strainu triaged this task as Unbreak Now! priority.EditedFeb 16 2024, 7:30 AM

Marking Unbreak Now as this will clearly cause some duplicate citations and some confusion to less experienced users while it's happening.

Strainu renamed this task from Cannot reuse citations in rowp to Cannot reuse VE citations in rowp.Feb 16 2024, 7:40 AM

In the JS console, the error is:

Uncaught TypeError: ref.insertReferenceNode is not a function
    onSearchResultsChoose ve.ui.CitoidInspector.js:354
    emit oojs.js:858
    chooseItem oojs-ui-core.js:8014
    onDocumentMouseUp oojs-ui-core.js:7347
Trizek-WMF renamed this task from Cannot reuse VE citations in rowp to Cannot reuse VE citations.Feb 16 2024, 8:40 AM
Trizek-WMF lowered the priority of this task from Unbreak Now! to High.

I confirm the bug, at other wikis.
I agree on the severity, but it is not an absolute blocking bug (VE not loading at all would be): I lower the priority and ping the engineers. (Don't forget that we are Friday.)

Change 1003843 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/Cite@wmf/1.42.0-wmf.18] Revert "Avoid creating a MWReferenceModel if not needed"

https://gerrit.wikimedia.org/r/1003843

Change 1003843 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.42.0-wmf.18] Revert "Avoid creating a MWReferenceModel if not needed"

https://gerrit.wikimedia.org/r/1003843

Mentioned in SAL (#wikimedia-operations) [2024-02-16T13:34:15Z] <hashar@deploy2002> Started scap: Backport for [[gerrit:1003843|Revert "Avoid creating a MWReferenceModel if not needed" (T357745)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-16T13:37:53Z] <hashar@deploy2002> matmarex and hashar: Backport for [[gerrit:1003843|Revert "Avoid creating a MWReferenceModel if not needed" (T357745)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-16T13:47:40Z] <hashar@deploy2002> Finished scap: Backport for [[gerrit:1003843|Revert "Avoid creating a MWReferenceModel if not needed" (T357745)]] (duration: 13m 24s)

Fix deployed to Wikimedia wikis.