Cannot reuse VE citations
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Strainu
	Feb 16 2024, 7:29 AM

Description

Browser:
FF 102.9.0esr (64-bit) on Windows
Edge 121.0.2277.112 (Official build) (64-bit)
Chrome 121.0.6167.86 (Official Build) (64-bit)

Steps to reproduce:

Open any rowp article with citations in Firefox
Add a new citation, go to the "Reuse citation" tab and click on any existing citation

Expected result: the clicked citation is added again
Actual result: cannot click on citations.

I tried in safe mode, same result.

Initially reported on wiki at https://ro.wikipedia.org/w/index.php?title=Wikipedia:Cafenea&oldid=16100461

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Avoid creating a MWReferenceModel if not needed"	mediawiki/extensions/Cite	wmf/1.42.0-wmf.18	+17 -13

Customize query in gerrit

Related Objects

Duplicates Merged Here: T357761: Re-using references on the VisualEditor does not seem to work

Event Timeline

Strainu created this task.Feb 16 2024, 7:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2024, 7:29 AM

Marking Unbreak Now as this will clearly cause some duplicate citations and some confusion to less experienced users while it's happening.

Strainu updated the task description. (Show Details)Feb 16 2024, 7:34 AM

Strainu renamed this task from Cannot reuse citations in rowp to Cannot reuse VE citations in rowp.Feb 16 2024, 7:40 AM

Strainu added a project: VisualEditor-MediaWiki-References.

In the JS console, the error is:

Uncaught TypeError: ref.insertReferenceNode is not a function
    onSearchResultsChoose ve.ui.CitoidInspector.js:354
    emit oojs.js:858
    chooseItem oojs-ui-core.js:8014
    onDocumentMouseUp oojs-ui-core.js:7347

Strainu added a subscriber: Trizek-WMF.Feb 16 2024, 7:56 AM

Trizek-WMF renamed this task from Cannot reuse VE citations in rowp to Cannot reuse VE citations.Feb 16 2024, 8:40 AM

Trizek-WMF lowered the priority of this task from Unbreak Now! to High.

I confirm the bug, at other wikis.
I agree on the severity, but it is not an absolute blocking bug (VE not loading at all would be): I lower the priority and ping the engineers. (Don't forget that we are Friday.)

I believe this would be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1003837, looking at timelines and commit messages.

matmarex merged a task: T357761: Re-using references on the VisualEditor does not seem to work.Feb 16 2024, 12:05 PM

matmarex added subscribers: GoEThe, matmarex.

Change 1003843 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/Cite@wmf/1.42.0-wmf.18] Revert "Avoid creating a MWReferenceModel if not needed"

https://gerrit.wikimedia.org/r/1003843

gerritbot added a project: Patch-For-Review.Feb 16 2024, 12:07 PM

Albertoleoncio merged a task: T357761: Re-using references on the VisualEditor does not seem to work.Feb 16 2024, 12:11 PM

Change 1003843 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.42.0-wmf.18] Revert "Avoid creating a MWReferenceModel if not needed"

https://gerrit.wikimedia.org/r/1003843

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2024, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-16T13:34:15Z] <hashar@deploy2002> Started scap: Backport for [[gerrit:1003843|Revert "Avoid creating a MWReferenceModel if not needed" (T357745)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-16T13:37:53Z] <hashar@deploy2002> matmarex and hashar: Backport for [[gerrit:1003843|Revert "Avoid creating a MWReferenceModel if not needed" (T357745)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-16T13:47:40Z] <hashar@deploy2002> Finished scap: Backport for [[gerrit:1003843|Revert "Avoid creating a MWReferenceModel if not needed" (T357745)]] (duration: 13m 24s)

Fix deployed to Wikimedia wikis.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 16 2024, 5:01 PM

Cannot reuse VE citationsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Cannot reuse VE citations
Closed, ResolvedPublicBUG REPORT
Actions