Page MenuHomePhabricator
Create Task
Maniphest T358342

No sound in uploaded videos
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?: The videos don't have audio, but the mp3 transcodes available have. The original videos have audio and uploaded in any other platform can be heard.

What should have happened instead?: They should have audio.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Fix regression in WebM transcodes breaking audiomediawiki/extensions/TimedMediaHandlerwmf/1.42.0-wmf.19+4 -2
Fix regression in WebM transcodes breaking audiomediawiki/extensions/TimedMediaHandlermaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Theklan created this task.Feb 23 2024, 2:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2024, 2:25 PM
Theklan added a comment.Feb 23 2024, 2:28 PM

This was just uploaded to see if the problem was with the video format, and the first transcoded version has sound, but the other ones don't. https://commons.wikimedia.org/wiki/File:Ikusgela-Zehaztasuneko_nekazaritza.webm

Theklan added a comment.Feb 23 2024, 2:30 PM

We are experiencing the same issue with every video: https://commons.wikimedia.org/wiki/Special:NewFiles?user=&mediatype%5B%5D=VIDEO&start=&end=&wpFormIdentifier=specialnewimages&limit=50&offset=

jeremyb-phone subscribed.Feb 23 2024, 5:25 PM
Wilfredor subscribed.Feb 24 2024, 10:08 AM
The_Squirrel_Conspiracy awarded a token.Feb 24 2024, 10:33 AM
Theklan added a project: TimedMediaHandler.Feb 24 2024, 12:21 PM
Theklan updated the task description. (Show Details)
bvibber claimed this task.Feb 24 2024, 1:03 PM
bvibber subscribed.

Oof, this is probably a regression from the recent bugfix for streaming tracks. Sorry, likely my fault! I'll double-check the code and see if I did something wrong shortly. If so I can re-run the affected transcodes after fix goes out, sigh...

gerritbot added a comment.Feb 24 2024, 1:25 PM

Change 1006131 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/TimedMediaHandler@master] Fix regression in WebM transcodes breaking audio

https://gerrit.wikimedia.org/r/1006131

gerritbot added a project: Patch-For-Review.Feb 24 2024, 1:25 PM
Prototyperspective subscribed.Feb 25 2024, 5:28 PM
Prototyperspective mentioned this in T358429: Uploaded video - Sound disappears on re-coded (downscaled) variants.Feb 25 2024, 9:15 PM
gerritbot added a comment.Feb 26 2024, 9:05 PM

Change 1006312 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/TimedMediaHandler@wmf/1.42.0-wmf.19] Fix regression in WebM transcodes breaking audio

https://gerrit.wikimedia.org/r/1006312

gerritbot added a comment.Feb 26 2024, 9:16 PM

Change 1006131 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Fix regression in WebM transcodes breaking audio

https://gerrit.wikimedia.org/r/1006131

gerritbot added a comment.Feb 26 2024, 9:27 PM

Change 1006312 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@wmf/1.42.0-wmf.19] Fix regression in WebM transcodes breaking audio

https://gerrit.wikimedia.org/r/1006312

Stashbot added a comment.Feb 26 2024, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-26T21:27:39Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:1006312|Fix regression in WebM transcodes breaking audio (T358342)]]

Stashbot added a comment.Feb 26 2024, 9:29 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-26T21:29:04Z] <cjming@deploy2002> cjming and bvibber: Backport for [[gerrit:1006312|Fix regression in WebM transcodes breaking audio (T358342)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2024, 9:30 PM
Stashbot added a comment.Feb 26 2024, 9:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-26T21:38:54Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:1006312|Fix regression in WebM transcodes breaking audio (T358342)]] (duration: 11m 14s)

bvibber added a comment.Feb 26 2024, 9:57 PM

Fix deployed, now re-running potentially affected files...

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 27 2024, 1:01 AM
Avsolov subscribed.Feb 27 2024, 7:00 PM
bvibber added a comment.Feb 27 2024, 10:36 PM

About halfway through reprocessing on Commons after 24 hours. Expect all affected Commons files re-run within next 24 hours, then I'll run a shorter job fixing up anything affected on other wikis.

bvibber changed the task status from Open to In Progress.Feb 29 2024, 5:11 PM

Should be fully resolved on Commons. I'll do a just-in-case run on affected date range on other wikis.

Theklan added a comment.Feb 29 2024, 5:44 PM

Thanks! It seems solved in the videos I have seen.

bvibber closed this task as Resolved.Feb 29 2024, 6:26 PM

aaaaaand last items have been run. :D

TheDJ merged a task: T358368: Commons media player removing audio from some videos.Mar 2 2024, 9:43 AM
TheDJ added subscribers: Sdkb, zhuyifei1999.
Aklapper merged a task: T358429: Uploaded video - Sound disappears on re-coded (downscaled) variants.Mar 18 2024, 1:10 PM
Aklapper added a subscriber: Nikolay_Komarov.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL