Page MenuHomePhabricator
Create Task
Maniphest T358394

Stop using internal PHPUnit code in Scribunto
Closed, ResolvedPublic
Actions

Description

PHPUnit 10 no longer invokes a static method called suite on test classes. Also, paratest (T50217) doesn't seem to work well with test classes that dynamically add more tests. For these reasons, Scribunto needs to stop relying on the suite method to define its test suites.

In general, the Scribunto test suite is quite "creative" and uses PHPUnit features that are marked as @internal in PHPUnit 10. An example issue this caused is T418217. All these should be avoided, in favour of a suite configuration that is supported by upstream.

Related: T345481 for removing the same deprecated pattern from core.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
PhpUnitSplitter: Remove Scribunto dynamic suite workaroundsSomeRandomDevelopermediawiki/coreREL1_43+1 -14
PhpUnitSplitter: Remove Scribunto dynamic suite workaroundsSomeRandomDevelopermediawiki/coreREL1_44+1 -14
tests: Adapt Scribunto test for LuaEngineTestBase getEngineName()SomeRandomDevelopermediawiki/extensions/ProofreadPageREL1_45+4 -0
tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6SomeRandomDevelopermediawiki/extensions/ProofreadPageREL1_45+77 -2
PhpUnitSplitter: Remove Scribunto dynamic suite workaroundsSomeRandomDevelopermediawiki/coreREL1_45+1 -14
Drop obsolete LuaEngineTestSkip splitter workaroundArendpietermediawiki/coremaster+0 -63
Adapt to Scribunto test changes (split tests, no more suite())Lucas Werkmeister (WMDE)mediawiki/extensions/WikibaseLexememaster+173 -49
tests: Replace dynamic suite building with standard class hierarchyArendpietermediawiki/extensions/Scribuntomaster+567 -208
Remove temporary suite() workaround for old ScribuntoArendpietermediawiki/extensions/JsonConfigmaster+31 -59
tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6Arendpietermediawiki/extensions/WikibaseMediaInfomaster+29 -1
tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6Arendpietermediawiki/extensions/ProofreadPagemaster+77 -2
tests: Adapt Scribunto test for LuaEngineTestBase getEngineName()Arendpietermediawiki/extensions/ProofreadPagemaster+4 -0
PhpUnitSplitter: Remove Scribunto dynamic suite workaroundsArendpietermediawiki/coremaster+1 -14
tests: Replace dynamic suite building with standard class hierarchyArendpietermediawiki/extensions/JsonConfigmaster+54 -33
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Feb 23 2024, 9:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2024, 9:55 PM
Daimona added a parent task: T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10.Feb 23 2024, 9:55 PM
Daimona added a parent task: T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel.Feb 24 2024, 7:23 PM
Daimona mentioned this in T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel.Feb 26 2024, 12:53 PM
Jdforrester-WMF subscribed.Feb 26 2024, 3:13 PM
Krinkle removed a project: MediaWiki-Core-Tests.Apr 22 2024, 9:04 PM
ArthurTaylor mentioned this in T379764: phpunit splitter fails with obscure error message when a data provider is invalid.Nov 15 2024, 1:52 PM
• This_was_the_i moved this task from Backlog to External on the Scribunto board.Mar 16 2025, 12:21 PM
Aklapper moved this task from External to Backlog on the Scribunto board.Apr 8 2025, 11:49 AM
Umherirrender mentioned this in T337135: Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static.May 20 2025, 6:34 PM
Daimona renamed this task from Stop using PHPUnit's TestSuite in Scribunto to Stop using internal PHPUnit code in Scribunto.Feb 25 2026, 12:02 PM
Daimona updated the task description. (Show Details)
Daimona mentioned this in T418217: wikibase-client-php83 CI fails: Class "LuaStandalone: Wikibase\Client\Tests\Integration\DataAccess\Scribunto\WikibaseEntityLibraryTest" does not exist.
WMDE-leszek subscribed.Feb 25 2026, 12:21 PM
ArthurTaylor subscribed.Feb 25 2026, 12:23 PM
gerritbot added a comment.Feb 25 2026, 4:18 PM

Change #1243878 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/Scribunto@master] tests: Replace dynamic suite building with standard class hierarchy

https://gerrit.wikimedia.org/r/1243878

gerritbot added a project: Patch-For-Review.Feb 25 2026, 4:18 PM
Arendpieter subscribed.Feb 25 2026, 4:19 PM
gerritbot added a comment.Feb 25 2026, 5:48 PM

Change #1243910 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/core@master] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1243910

gerritbot added a comment.Feb 25 2026, 6:18 PM

Change #1243928 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/JsonConfig@master] tests: Replace dynamic suite building with standard class hierarchy

https://gerrit.wikimedia.org/r/1243928

Novem_Linguae subscribed.Feb 25 2026, 8:13 PM
Arendpieter added a comment.Feb 25 2026, 8:15 PM

@Jdforrester-WMF The merge order needs to be: Core → JsonConfig → Scribunto. I’m not very familiar with Gerrit’s Depends-On feature yet, but that was my plan.

Jdforrester-WMF added a comment.Feb 25 2026, 8:21 PM

[Conversation moved from gerrit.]

In T358394#11652234, @Arendpieter wrote:

@Jdforrester-WMF The merge order needs to be: Core → JsonConfig → Scribunto. I’m not very familiar with Gerrit’s Depends-On feature yet, but that was my plan.

OK, so the core change won't actually break CI for Scribunto? If it did the CI wouldn't currently be passing for the core change, as it and any extension that depends on Scribunto (currently 16) have Scribunto's tests run for any change. Hmm, OK, that's plausible.

gerritbot added a comment.Feb 25 2026, 8:35 PM

Change #1243956 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/ProofreadPage@master] tests: Adapt Scribunto test for LuaEngineTestBase getEngineName()

https://gerrit.wikimedia.org/r/1243956

gerritbot added a comment.Feb 25 2026, 8:52 PM

Change #1243910 merged by jenkins-bot:

[mediawiki/core@master] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1243910

gerritbot added a comment.Feb 25 2026, 8:53 PM

Change #1243928 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] tests: Replace dynamic suite building with standard class hierarchy

https://gerrit.wikimedia.org/r/1243928

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Feb 25 2026, 9:00 PM
gerritbot added a comment.Feb 26 2026, 6:16 AM

Change #1243956 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] tests: Adapt Scribunto test for LuaEngineTestBase getEngineName()

https://gerrit.wikimedia.org/r/1243956

gerritbot added a comment.Feb 26 2026, 8:50 AM

Change #1244568 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/ProofreadPage@master] tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6

https://gerrit.wikimedia.org/r/1244568

gerritbot added a comment.Feb 26 2026, 9:33 AM

Change #1244590 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/WikibaseMediaInfo@master] tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6

https://gerrit.wikimedia.org/r/1244590

gerritbot added a comment.Feb 26 2026, 10:56 AM

Change #1244568 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6

https://gerrit.wikimedia.org/r/1244568

gerritbot added a comment.Feb 26 2026, 4:42 PM

Change #1244711 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/JsonConfig@master] Remove temporary suite() workaround for old Scribunto

https://gerrit.wikimedia.org/r/1244711

gerritbot added a comment.Feb 26 2026, 4:46 PM

Change #1244590 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6

https://gerrit.wikimedia.org/r/1244590

Arendpieter added a comment.Feb 27 2026, 2:43 PM

@Jdforrester-WMF I finally fixed all CI errors. The merge order is now Scribuntu → JsonConfig. The latter removes the temporary suite() workaround for the old Scribunto, which was needed because of a dependency cycle.

gerritbot added a comment.Mar 2 2026, 2:54 PM

Change #1243878 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] tests: Replace dynamic suite building with standard class hierarchy

https://gerrit.wikimedia.org/r/1243878

gerritbot added a comment.Mar 2 2026, 2:56 PM

Change #1244711 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Remove temporary suite() workaround for old Scribunto

https://gerrit.wikimedia.org/r/1244711

Jdforrester-WMF closed this task as Resolved.Mar 2 2026, 2:57 PM
Jdforrester-WMF assigned this task to Arendpieter.

Superb work, thank you!

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2026, 3:32 PM
Lucas_Werkmeister_WMDE mentioned this in T418774: Wikibase CI broken: Call to undefined method WikibaseLibraryTestCase::suite().Mar 2 2026, 5:20 PM
gerritbot added a comment.Mar 2 2026, 5:39 PM

Change #1247121 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Adapt to Scribunto test changes (split tests, no more suite())

https://gerrit.wikimedia.org/r/1247121

gerritbot added a project: Patch-For-Review.Mar 2 2026, 5:39 PM
Daimona mentioned this in T345481: Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing.Mar 3 2026, 3:52 PM
gerritbot added a comment.Mar 4 2026, 1:23 PM

Change #1247121 merged by Jforrester:

[mediawiki/extensions/WikibaseLexeme@master] Adapt to Scribunto test changes (split tests, no more suite())

https://gerrit.wikimedia.org/r/1247121

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2026, 1:30 PM
gerritbot added a comment.Mar 12 2026, 10:11 AM

Change #1251027 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/core@master] Drop obsolete LuaEngineTestSkip splitter workaround

https://gerrit.wikimedia.org/r/1251027

gerritbot added a project: Patch-For-Review.Mar 12 2026, 10:11 AM
gerritbot added a comment.Mar 12 2026, 11:42 AM

Change #1251027 merged by jenkins-bot:

[mediawiki/core@master] Drop obsolete LuaEngineTestSkip splitter workaround

https://gerrit.wikimedia.org/r/1251027

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Mar 12 2026, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2026, 12:30 PM
gerritbot added a comment.May 3 2026, 10:01 PM

Change #1282056 had a related patch set uploaded (by SomeRandomDeveloper; author: Arendpieter):

[mediawiki/extensions/ProofreadPage@REL1_45] tests: Adapt Scribunto test for LuaEngineTestBase getEngineName()

https://gerrit.wikimedia.org/r/1282056

gerritbot added a project: Patch-For-Review.May 3 2026, 10:01 PM

Change #1282057 had a related patch set uploaded (by SomeRandomDeveloper; author: Arendpieter):

[mediawiki/extensions/ProofreadPage@REL1_45] tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6

https://gerrit.wikimedia.org/r/1282057

gerritbot added a comment.May 3 2026, 11:10 PM

Change #1282063 had a related patch set uploaded (by SomeRandomDeveloper; author: Arendpieter):

[mediawiki/core@REL1_45] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1282063

gerritbot added a comment.May 3 2026, 11:31 PM

Change #1282063 merged by jenkins-bot:

[mediawiki/core@REL1_45] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1282063

gerritbot added a comment.May 3 2026, 11:37 PM

Change #1282057 abandoned by SomeRandomDeveloper:

[mediawiki/extensions/ProofreadPage@REL1_45] tests: Rename abstract *Test classes to *TestBase for PHPUnit 9.6

https://gerrit.wikimedia.org/r/1282057

gerritbot added a comment.May 3 2026, 11:37 PM

Change #1282056 abandoned by SomeRandomDeveloper:

[mediawiki/extensions/ProofreadPage@REL1_45] tests: Adapt Scribunto test for LuaEngineTestBase getEngineName()

https://gerrit.wikimedia.org/r/1282056

gerritbot added a comment.May 3 2026, 11:38 PM

Change #1282064 had a related patch set uploaded (by SomeRandomDeveloper; author: Arendpieter):

[mediawiki/core@REL1_44] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1282064

gerritbot added a comment.May 3 2026, 11:41 PM

Change #1282066 had a related patch set uploaded (by SomeRandomDeveloper; author: Arendpieter):

[mediawiki/core@REL1_43] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1282066

ReleaseTaggerBot added a project: MW-1.45-notes.May 4 2026, 12:00 AM
gerritbot added a comment.May 4 2026, 12:03 AM

Change #1282064 merged by jenkins-bot:

[mediawiki/core@REL1_44] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1282064

gerritbot added a comment.May 4 2026, 12:04 AM

Change #1282066 merged by jenkins-bot:

[mediawiki/core@REL1_43] PhpUnitSplitter: Remove Scribunto dynamic suite workarounds

https://gerrit.wikimedia.org/r/1282066

Maintenance_bot removed a project: Patch-For-Review.May 4 2026, 12:30 AM
ReleaseTaggerBot added projects: MW-1.44-notes, MW-1.43-notes.May 4 2026, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits