Page MenuHomePhabricator

Failure when publishing Flickr upload (this.sourceInput is undefined)
Closed, ResolvedPublicBUG REPORT

Description

When clicking publish after entering the metadata for a Flickr image, UploadWizard hangs at the 'Submitting details…' stage, with the below error in the console.

Screenshot 2024-02-24 at 10-24-02 Upload Wizard - Wikimedia Commons.png (404×925 px, 109 KB)

URL: https://commons.wikimedia.org/wiki/Special:UploadWizard?debug=1

jQuery.Deferred exception: this.sourceInput is undefined uw.deed.Abstract.prototype.getSourceWikiText@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/deed/uw.deed.ThirdParty.js?d5041:333:3
getWikiText@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/mw.UploadWizardDetails.js?d2e32:795:30
submit@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/mw.UploadWizardDetails.js?d2e32:863:20
uw.controller.Details.prototype.transitionOne@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/controller/uw.controller.Details.js?179f5:274:25
uw.ConcurrentQueue.prototype.executeNext@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/uw.ConcurrentQueue.js?77946:146:25
uw.ConcurrentQueue.prototype.startExecuting@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/uw.ConcurrentQueue.js?77946:164:9
uw.controller.Details.prototype.transitionAll@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/controller/uw.controller.Details.js?179f5:294:14
uw.controller.Details.prototype.submit@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/controller/uw.controller.Details.js?179f5:321:15
uw.controller.Details.prototype.startDetails/<@https://commons.wikimedia.org/w/extensions/UploadWizard/resources/controller/uw.controller.Details.js?179f5:156:13
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3548:46
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3587:9
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3489:29
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
add@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3282:7
Deferred/then/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3622:24
Deferred@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3713:9
then@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3607:20
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3527:17
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3361:10
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
when/updateFunc/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3743:15
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3548:46
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3587:9
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3489:29
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
add@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3282:7
Deferred/then/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3622:24
Deferred@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3713:9
then@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3607:20
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3527:17
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3361:10
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
when/updateFunc/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3743:15
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3548:46
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3587:9
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3489:29
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
add@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3282:7
Deferred/then/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3622:24
Deferred@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3713:9
then@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3607:20
mightThrow@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3527:17
Deferred/then/resolve/</process<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3557:12
setTimeout handler*Deferred/then/resolve/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3602:16
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3361:10
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
fireWith@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3353:7
when/updateFunc/<@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3743:15
fire@https://commons.wikimedia.org/w/resources/lib/jquery/jquery.js?12e87:3223:31
 undefined jquery.js:3783:18

Event Timeline

Change 1006502 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Restore uw.deed.Custom.js methods

https://gerrit.wikimedia.org/r/1006502

Change 1006502 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Restore uw.deed.Custom.js methods

https://gerrit.wikimedia.org/r/1006502

Cannot currently test on commons beta due to

Content-Security-Policy: The page’s settings blocked the loading of a resource at https://api.flickr.com/services/rest/?&api_key=e9d8174a79c782745289969a45d350e8&format=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo (“default-src”)


 Refused to connect to 'https://api.flickr.com/services/rest/?&api_key=e9d8174a79c782745289969a45d350e8&format=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo' because it violates the following Content Security Policy directive: "default-src 'self' data: blob: https://upload.wikimedia.beta.wmflabs.org [...]
  • The same flickr link doesn't produce this error in production
  • disabling Content Security Policy in FF doesn't seem to be working

Checked in commons wmf.20 - works as expected.

In Add data step flickr-uploaded files are not displayed - 'uploadstash-file-not-found' error in the Console. Filed as T358726.