Page MenuHomePhabricator

Can't unlink non-existing P&E Dashboard courses from events
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create an event with no P&E Dashboard course attached
  • By querying the database directly, add a non-existing P&E Dashboard course to the event you just created (e.g., use gibberish as course name)
    • I think the bug may also be reproducible by deleting the course in the Dashboard, but I haven't tested that.
  • Go to Special:EditEventRegistration for that event
  • Replace the non-existing course with one that exists
  • Submit the form

What happens?:
You see the following error:

The course <name of the nonexisting course you entered in the DB> does not exist in the Programs & Events Dashboard.

And you cannot submit the form.

What should have happened instead?:
The submission should still go through because the non-existing course is being removed, so we don't really need to check if it exists.

Software version (skip for WMF-hosted wikis like Wikipedia): master

Other information (browser name/version, screenshots, etc.): ∅

Event Timeline

Change 1007460 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] WikiEduDashboard: allow removal when course doesn't exist

https://gerrit.wikimedia.org/r/1007460

Change 1007460 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] WikiEduDashboard: allow removal when course doesn't exist

https://gerrit.wikimedia.org/r/1007460

✅ This is working correctly on betacluster now. I checked against it on meta (where it has not been released yet) and the following instructions are able to reproduce the bug on meta:

Create an event in campaign events registration
Create a p&e dashboard program
Add p&e dashboard program to the event in campaign events registration
Delete campaign from the p&e dashboard
Delete the p&e dashboard program
Create a new p&e dashboard program
Add the new p&e dashboard program to the campaign events registration

I'm going to keep this in QA until it is released to meta just to make sure it will work correctly there too.

(QA note to self - Here is the p&e dashboard link to replace the current one that is in this event in meta where it currently shows an error when replacing the deleted d&e dashboard event)

Functioning correctly in betaclusterfailing in meta (to recheck after release)
Screen Recording 2024-03-12 at 3.39.32 PM.gif (1×1 px, 3 MB)
Screenshot 2024-03-12 at 4.24.23 PM.png (1×1 px, 315 KB)

✅ This is working correctly on betacluster now. I checked against it on meta (where it has not been released yet) and the following instructions are able to reproduce the bug on meta:

Create an event in campaign events registration
Create a p&e dashboard program
Add p&e dashboard program to the event in campaign events registration
Delete campaign from the p&e dashboard
Delete the p&e dashboard program
Create a new p&e dashboard program
Add the new p&e dashboard program to the campaign events registration

I'm going to keep this in QA until it is released to meta just to make sure it will work correctly there too.

(QA note to self - Here is the p&e dashboard link to replace the current one that is in this event in meta where it currently shows an error when replacing the deleted d&e dashboard event)

Functioning correctly in betaclusterfailing in meta (to recheck after release)
Screen Recording 2024-03-12 at 3.39.32 PM.gif (1×1 px, 3 MB)
Screenshot 2024-03-12 at 4.24.23 PM.png (1×1 px, 315 KB)

✅ This is now released and working correctly on meta as well. Sending this to product sign off.

Screen Recording 2024-03-13 at 2.05.17 PM.gif (1×1 px, 1 MB)

ifried subscribed.

This has been released, so I'm marking it as Done.