Peast complains about backslash that is part of a regex in valid JS code
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Msz2001
	Mar 2 2024, 9:41 AM

Description

Steps to replicate the issue (include links if applicable):

Navigate to plwiki
Type mw.loader.load('ext.gadget.wp_sk-T358946') in browser console

What happens?:
An error is displayed in the console:

ext.gadget.wp_sk-script-0.js:
Parse error: Unexpected \ on line 910

What should have happened instead?:
The gadget should have been loaded as it used to before wmf.20 deployment

Software version (skip for WMF-hosted wikis like Wikipedia): wmf.20

Other information (browser name/version, screenshots, etc.):
The linter complains about this line: https://pl.wikipedia.org/wiki/MediaWiki:Gadget-sk.js#L-910 which is syntactically correct. The file hasn't been changed significantly for a few weeks and all the recent changes in that file were to overcome this error.

The error is present in ResourceLoader output, implying that the linter fails to recognize something in the code: https://pl.wikipedia.org/w/load.php?lang=pl&modules=ext.gadget.wp_sk-T358946&skin=vector

The error has been firstly reported after an hour of deploying MediaWiki 1.42-wmf.20 to plwiki.

(Edited the task to use a gadget copy, the main one has been hotfixed)

Details

	Subject	Repo	Branch	Lines +/-
	Update mck89/peast to 1.16.2	mediawiki/core	master	+2 -2
	Update mck89/peast to 1.16.2	mediawiki/vendor	master	+31 -23

Customize query in gerrit

Related Objects

Mentioned In: T359014: XFDcloser gadget intermittently failing Peast validation
Mentioned Here: T357477: InvalidArgumentException: Script must be a string or array

Event Timeline

Msz2001 created this task.Mar 2 2024, 9:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2024, 9:41 AM

Msz2001 added a project: MediaWiki-ResourceLoader.Mar 2 2024, 9:51 AM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 2 2024, 9:51 AM

which linter, the editor one, or the one that parses the page when you submit to save ?

This is about the Peast validator used by ResourceLoader at serve-time.

The one that's used by the ResourceLoader to ensure users won't get syntactically incorrect code. The one in the editor flags no error (only some warnings and infos and none of them is around the problematic 910th line).

The page can be saved without any trouble.

TheDJ renamed this task from MediaWiki JS linter complains about backslash in correct code to Peast complains about backslash that is part of a regex in valid JS code.Mar 2 2024, 10:23 AM

PeterBowman subscribed.Mar 2 2024, 11:32 AM

I reproduced locally, it's caused by the mck89/peast upgrade from T357477 (which fixed a different bug like this). That was already deployed a week ago, but I guess we cache these for a while.

Msz2001 updated the task description. (Show Details)Mar 2 2024, 5:01 PM

I applied a temporary workaround in the gadget: https://pl.wikipedia.org/w/index.php?title=MediaWiki:Gadget-sk.js&diff=prev&oldid=73036090

Minimal test case: Peast\Peast::ES2016( '/=\n/' )->parse();

Upstream has been responsive. Could you file an upstream bug report?

matmarex mentioned this in T359014: XFDcloser gadget intermittently failing Peast validation.Mar 4 2024, 4:14 PM

larissagaulia moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.Mar 4 2024, 4:15 PM

Krinkle removed projects: JavaScript, MediaWiki-extensions-Gadgets.Mar 4 2024, 4:18 PM

The plwiki script has been reworked to avoid ResourceLoader minification, so this isn't urgent at this point. See:

Reported upstream: https://github.com/mck89/peast/issues/68

Krinkle triaged this task as High priority.Mar 5 2024, 4:05 PM

Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.

Change 1008953 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Update mck89/peast to 1.16.2

https://gerrit.wikimedia.org/r/1008953

gerritbot added a project: Patch-For-Review.Mar 5 2024, 9:05 PM

Change 1008954 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/vendor@master] Update mck89/peast to 1.16.2

https://gerrit.wikimedia.org/r/1008954

matmarex moved this task from Blocked/waiting to Current Sprint on the MediaWiki-Platform-Team board.Mar 5 2024, 9:12 PM

Change 1008954 merged by jenkins-bot:

[mediawiki/vendor@master] Update mck89/peast to 1.16.2

https://gerrit.wikimedia.org/r/1008954

Change 1008953 merged by jenkins-bot: