[WtC-M3] [QB] Replace WiKit Message component by Codex's
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	Arian_Bozorg
	Mar 11 2024, 3:26 PM

Description

Problem

The Query Builder's user interface was composed using a combination of Vue 2 custom components and WiKit elements, such as Message. The WiKit design system is now on its deprecation path, as it has been superseded by Codex, the official Wikimedia design system. The utilization of WiKit components is not recommended, and they should be replaced in order to reduce maintenance costs and ensure consistency.

Solution

We have to replace the WiKit Message by the Codex equivalent: cdx-message(See demo). This will take us a step closer to switching to the new design system and deprecating the old.

Acceptance criteria

All types of WiKit Messages used in Query Builder are replaced by their Codex equivalent

Details

	Subject	Repo	Branch	Lines +/-
	Rewrite QueryResults in <script setup> syntax	wikidata/query-builder	master	+14 -27
	Replace Wikit Message usage with Codex in QueryResult.vue	wikidata/query-builder	master	+4 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T327532 [EPIC] [WtC] Migrate WiKit-built products to Codex
Open	karapayneWMDE	T380280 [Epic] Deprecating Quality Tools functional team
Open	None	T327680 [WtC] [EPIC] Migrate Query Builder to Codex
Open	None	T359842 [WtC-M3] [QB] [EPIC] Replace WiKit components by available Codex components
Open	ItamarWMDE	T359860 [WtC-M3] [QB] Replace WiKit Message component by Codex's

Event Timeline

Arian_Bozorg created this task.Mar 11 2024, 3:26 PM

Arian_Bozorg mentioned this in T359842: [WtC-M3] [QB] [EPIC] Replace WiKit components by available Codex components.Mar 11 2024, 3:34 PM

Arian_Bozorg renamed this task from [SW] [WtC-M2] [QB] Replace WiKit Message component by Codex's to [SW] [WtC-M3] [QB] Replace WiKit Message component by Codex's.Mar 11 2024, 3:44 PM

karapayneWMDE moved this task from Incoming to UX Backlog on the Wikidata Dev Team board.Mar 12 2024, 3:11 PM

Arian_Bozorg renamed this task from [SW] [WtC-M3] [QB] Replace WiKit Message component by Codex's to [WtC-M3] [QB] Replace WiKit Message component by Codex's.Jun 5 2024, 11:04 AM

Arian_Bozorg moved this task from UX Backlog to Unified QT Backlog on the Wikidata Dev Team board.Jun 5 2024, 11:44 AM

This task will require design verification. Please ping Charlie Kritschmar whenever the ticket is ready to be reviewed. Thank you!

Arian_Bozorg moved this task from Unified QT Backlog to Quality Tools "Sprint" on the Wikidata Dev Team board.Aug 6 2024, 8:10 AM

Arian_Bozorg edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team.

ArthurTaylor mentioned this in T370055: [SW] [WtC-M2] [SNL] Replace WiKit Message component by Codex's.Sep 19 2024, 10:38 AM

ItamarWMDE claimed this task.Sep 25 2024, 3:37 PM

ItamarWMDE moved this task from Backlog to Doing on the Wikidata Dev Team (Quality Tools "Sprint") board.

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptSep 25 2024, 3:37 PM

Change #1075962 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[wikidata/query-builder@master] Replace Wikit Message usage with Codex in QueryResult.vue

https://gerrit.wikimedia.org/r/1075962

gerritbot added a project: Patch-For-Review.Sep 26 2024, 4:38 PM

Hey hey @Charlie_WMDE, here's another change to review :D thank you! https://1075962--clicky-sparqly.netlify.app/

Change #1075964 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[wikidata/query-builder@master] Rewrite QueryResults in <script setup> syntax

https://gerrit.wikimedia.org/r/1075964

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board.Sep 26 2024, 4:56 PM

Hey @ItamarWMDE

all looks good to me except in RTL it seems like the spacing between the text and the icon is not respected. could you have a look?

I can't test the error message because I can't trigger it currently as mentioned in the T359861 ticket

In T359860#10186963, @Charlie_WMDE wrote:

Hey @ItamarWMDE

all looks good to me except in RTL it seems like the spacing between the text and the icon is not respected. could you have a look?

Nice Catch! I should test more often in my native language 😅. This also helped resolve a mysterious issue we had with the whole condition not fitting into one row. Check out https://1075962--clicky-sparqly.netlify.app/ again to revalidate.

I can't test the error message because I can't trigger it currently as mentioned in the T359861 ticket

For some reason on this change (as opposed to T359861: [WtC-M3] [QB] Replace WiKit TextInput component by Codex's) I am able to reproduce the lack of validation. Something very odd is afoot. What do you say we put a pin in it (by creating a separate bug ticket) and perhaps getting back to it after the migration is done, to make sure that everything is fixed by then?

Nice Catch! I should test more often in my native language 😅. This also helped resolve a mysterious issue we had with the whole condition not fitting into one row. Check out https://1075962--clicky-sparqly.netlify.app/ again to revalidate.

Yay, that's awesome, looks good now, thanks!

For some reason on this change (as opposed to T359861: [WtC-M3] [QB] Replace WiKit TextInput component by Codex's) I am able to reproduce the lack of validation. Something very odd is afoot. What do you say we put a pin in it (by creating a separate bug ticket) and perhaps getting back to it after the migration is done, to make sure that everything is fixed by then?

sounds good to me 👍

ItamarWMDE moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Quality Tools "Sprint") board.Oct 11 2024, 9:07 AM

Change #1075962 merged by jenkins-bot: