Page MenuHomePhabricator
Create Task
Maniphest T360002

Retain bold text formatting while adding a Wikipedia Preview
Closed, ResolvedPublic
Actions

Description

Problem

When adding a Wikipedia Preview to bold text, the bold formatting is lost, affecting the visual emphasis intended by the editor. Italicized or underline text is not affected by this issue.

Solution

Modify the Wikipedia Preview plugin to preserve the original text formatting when a preview is added.

Test Scenarios
  • Add a Wikipedia Preview to bold text; verify the bold formatting is preserved.
  • Add a Wikipedia Preview to italicized text; confirm italics remain intact.
  • Add previews to text with both bold and italicized formatting; both formats should be preserved.
Acceptance Criteria:
  • Text formatting is retained when a Wikipedia Preview is added.
  • The solution does not impact the plugin's performance or interfere with other formatting features.

QA Results - Wordpress Dev 6.5

ACStatusDetails
1 ✅https://phabricator.wikimedia.org/T360002 here

Related Objects
Search...

Event Timeline

SGautam_WMF created this task.Mar 13 2024, 4:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2024, 4:24 AM
PWaigi-WMF added a parent task: T327100: Improve Experience for Site Owners & Readers using Wikipedia Preview Plugin.Mar 13 2024, 1:15 PM
PWaigi-WMF triaged this task as Medium priority.Mar 13 2024, 1:38 PM
hueitan claimed this task.Apr 2 2024, 4:07 AM
hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
hueitan added a comment.Wed, Apr 3, 11:50 AM

PR: https://github.com/wikimedia/wikipedia-preview/pull/192

hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Wed, Apr 3, 12:03 PM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Fri, Apr 5, 4:42 PM
GMikesell-WMF subscribed.Fri, Apr 5, 10:21 PM

@hueitan I'm on the latest WordPress and Wikipreview as seen below but I'm still coming across the same issue with bold not working when selecting Wikipreview. Am I missing something?

Status: ❌ FAIL
Environment: WordPress Dev- 6.5; Wikipreview: 1.12.0; Commit: 72f4c09a097ddeb58e96d82e411a53cb43c77a10, Fri Apr 5 12:38:09 2024 -0400
OS: macOS Sonoma 14.2
Browser: Chrome 123
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://dev-test.local/philadelphia-eagles-test/

❌AC1: https://phabricator.wikimedia.org/T360002

GMikesell-WMF updated the task description. (Show Details)Fri, Apr 5, 10:22 PM
GMikesell-WMF added a comment.EditedMon, Apr 8, 6:46 PM

@hueitan Both bold and italicized formats are both preserved as seen in the video below. I just need to ran npm build to have it fully integrated compared to without which is the video previously. I will move this to design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: WordPress Dev- 6.5; Wikipreview: 1.12.0; Commit: 72f4c09a097ddeb58e96d82e411a53cb43c77a10, Fri Apr 5 12:38:09 2024 -0400
OS: macOS Sonoma 14.2
Browser: Chrome 123
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://dev-test.local/philadelphia-eagles-test/

✅AC1: https://phabricator.wikimedia.org/T360002

GMikesell-WMF updated the task description. (Show Details)Mon, Apr 8, 6:48 PM
GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.
SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Tue, Apr 16, 10:34 AM
PWaigi-WMF closed this task as Resolved.Tue, Apr 16, 12:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL