Alter "This has moved" popup font size
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 18 2024, 3:51 PM

Description

Spun out of T360143 (per @JScherer-WMF T360143#9638427)

Re: font-size in this notification. It should take on whatever the small size is for a given setting. Not sure what the names of the specific variables are for that, though.

body size name	body size px	`small` size	Note
small	14	14
standard	16	14
large	20	14	This is incorrect, but will likely be adjusted later on

QA Results - PROD

AC	Status	Details
1	✅	T360335#9847345

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	vector-popup-notification: Use 14px font size instead of 16px	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T365385: Verify 1.43.0-wmf.6 deployment
T360143: Suggested design changes to Popups
Mentioned Here: T363845: [EPIC] Typography scale and font sizing
T360143: Suggested design changes to Popups

Event Timeline

Jdlrobson created this task.Mar 18 2024, 3:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2024, 3:51 PM

Jdlrobson mentioned this in T360143: Suggested design changes to Popups.Mar 18 2024, 3:51 PM

Change 1011166 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/skins/Vector@master] vector-popup-notification: Use 14px font size instead of 16px

https://gerrit.wikimedia.org/r/1011166

gerritbot added a project: Patch-For-Review.Mar 18 2024, 3:51 PM

The above patch uses the same variable as used in the other popup/dropdown menus (@font-size-dropdown). Presumably this will get migrated to the small/standard/large CSS variables when that switch happens.

ovasileva triaged this task as Medium priority.Mar 19 2024, 1:49 PM

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6); removed Web-Team-Backlog-Archived.

ovasileva raised the priority of this task from Medium to High.Mar 26 2024, 8:11 AM

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1); removed Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 6).

ovasileva lowered the priority of this task from High to Medium.Apr 9 2024, 10:58 AM

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2); removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 1).Apr 10 2024, 6:55 AM

Jdlrobson edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 2).Apr 23 2024, 5:25 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bffad1a730/w

JScherer-WMF attached a referenced file: F42625813: image.png. (Show Details)May 20 2024, 9:29 PM

Change #1011166 merged by jenkins-bot:

[mediawiki/skins/Vector@master] vector-popup-notification: Use 14px font size instead of 16px

https://gerrit.wikimedia.org/r/1011166

After talking to Justin (DM) we'll handle updating the font size in large mode in T363845.

Jdlrobson updated the task description. (Show Details)May 20 2024, 10:59 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 20 2024, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 20 2024, 11:31 PM

Edtadros mentioned this in T365385: Verify 1.43.0-wmf.6 deployment.May 28 2024, 10:05 PM

@Jdlrobson I just wanted to confirm if this QA testable or not.

I have verified in production that the font size of the popup is always 14px.

GMikesell-WMF updated the task description. (Show Details)May 30 2024, 4:11 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo-legacy.wmcloud.org/wikis/bffad1a730/w/~~

Alter "This has moved" popup font sizeClosed, ResolvedPublicActions