| Jdlrobson | |
| Mar 18 2024, 3:51 PM |
| F42625813: image.png | |
| Mar 18 2024, 3:51 PM |
Spun out of T360143 (per @JScherer-WMF T360143#9638427)
Re: font-size in this notification. It should take on whatever the small size is for a given setting. Not sure what the names of the specific variables are for that, though.
| body size name | body size px | small size | Note |
| small | 14 | 14 | |
| standard | 16 | 14 | |
| large | 20 | 14 | This is incorrect, but will likely be adjusted later on |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T360335#9847345 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| vector-popup-notification: Use 14px font size instead of 16px | mediawiki/skins/Vector | master | +1 -1 |
Change 1011166 had a related patch set uploaded (by Jdlrobson; author: Esanders):
[mediawiki/skins/Vector@master] vector-popup-notification: Use 14px font size instead of 16px
The above patch uses the same variable as used in the other popup/dropdown menus (@font-size-dropdown). Presumably this will get migrated to the small/standard/large CSS variables when that switch happens.
Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bffad1a730/w
Change #1011166 merged by jenkins-bot:
[mediawiki/skins/Vector@master] vector-popup-notification: Use 14px font size instead of 16px
After talking to Justin (DM) we'll handle updating the font size in large mode in T363845.