Page MenuHomePhabricator

Alter "This has moved" popup font size
Closed, ResolvedPublic


Spun out of T360143 (per @JScherer-WMF T360143#9638427)

Re: font-size in this notification. It should take on whatever the small size is for a given setting. Not sure what the names of the specific variables are for that, though.

body size namebody size pxsmall sizeNote
large2014This is incorrect, but will likely be adjusted later on

image.png (157×389 px, 11 KB)

QA Results - PROD


Event Timeline

Change 1011166 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/skins/Vector@master] vector-popup-notification: Use 14px font size instead of 16px

The above patch uses the same variable as used in the other popup/dropdown menus (@font-size-dropdown). Presumably this will get migrated to the small/standard/large CSS variables when that switch happens.

ovasileva lowered the priority of this task from High to Medium.Apr 9 2024, 10:58 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:

Change #1011166 merged by jenkins-bot:

[mediawiki/skins/Vector@master] vector-popup-notification: Use 14px font size instead of 16px

Jdlrobson claimed this task.

After talking to Justin (DM) we'll handle updating the font size in large mode in T363845.

@Jdlrobson I just wanted to confirm if this QA testable or not.

I have verified in production that the font size of the popup is always 14px.