Page MenuHomePhabricator

Impact Module: update Thanks tooltip copy
Open, MediumPublic

Assigned To
Authored By
KStoller-WMF
Mar 19 2024, 10:17 PM
Referenced Files
F60519193: Screenshot 2025-05-25 at 1.46.23 PM.png
May 25 2025, 8:49 PM
F59961501: Screenshot 2025-05-14 at 1.16.07 AM.png
May 14 2025, 8:17 AM
F59961397: Screenshot 2025-05-14 at 1.09.17 AM.png
May 14 2025, 8:13 AM
F59311101: Capture-2025-04-20-082514.png
Apr 20 2025, 3:28 PM
F58953160: Screenshot 2025-03-31 at 10.50.56.png
Mar 31 2025, 5:55 PM
F58953118: Screenshot 2025-03-31 at 10.52.39.png
Mar 31 2025, 5:55 PM
Restricted File
Mar 31 2025, 1:21 AM
F58923364: Screenshot 2025-03-26 at 00.34.22.png
Mar 26 2025, 7:34 AM

Description

As an editor viewing my impact module, I want to understand the metrics, so that the data is meaningful to me.

Background:

We've received quite a few questions about how certain data on the impact module is calculated. And some of the metrics have limits or data caps to how many prior edits are calculated.

In reviewing the "Thanks received" tooltip info with engineers, it came to my attention that the explanation is incorrect.

Screenshot 2023-11-29 at 3.59.09 PM.png (1×490 px, 125 KB)

Background:

The copy on the 'Thanks received' info tooltip should changed, since it was discovered the current copy isn't accurate.

The current copy says the metric is limited to "most recent 1,000 edits" but it is actually limited to an editor's most recent 1,000 Thanks received."

Design:

Popup button widget.png (183×322 px, 15 KB)

Copy:

"Wikipedia is created by a community of editors like you. You may be thanked by another contributor for an edit you’ve made, and you can thank others for their edits too. This metric will display a maximum of a 1,000 Thanks received, even if your actual total is higher."

TBD:

Should we also link our to the Impact Module help page for further information on data: https://www.mediawiki.org/wiki/Help:Growth/Tools/Impact_module

Acceptance Criteria:

Given I want to learn more about Thanks Received,
When I can click on the module's info tooltip,
Then I can learn the basics
(TBD) And also link out to the associated Growth team help page about the Impact module to learn even more

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Hi @Sgs,

I am a new contributor, can I take this task?

@Hxfff000 I think this would be a great task to start with! Essentially it just requires updating the copy.

Thank you so much! If I have question I will post here

Sounds good!
I've moved the task into Growth's "Current Sprint" just so the rest of the team knows this task is in progress.

Thanks for interest in this task, and let us know if you run into questions. :)

Thank you.

I have a question for setting up the environment.
I have .env file in the root directory and pasted what is been ask.
For the next step I need to echo to .env file this command
echo "MW_DOCKER_UID=$(id -u)
MW_DOCKER_GID=$(id -g)" >> .env
But what is the user id and group id. Is this about Gerrit account or Docker account?

Thank you.

I have a question for setting up the environment.
I have .env file in the root directory and pasted what is been ask.
For the next step I need to echo to .env file this command
echo "MW_DOCKER_UID=$(id -u)
MW_DOCKER_GID=$(id -g)" >> .env
But what is the user id and group id. Is this about Gerrit account or Docker account?

This is about the Linux id command: https://www.gnu.org/software/coreutils/manual/html_node/id-invocation.html and your local user and group id. (I assume it is available on Mac as well? But I have no idea.)

So, you can just execute that exactly as written, you don't need to replace anything. The point is that this command, as it is, will write the correct values to the .env file.

I see, thank you for the explanation

Hello, I set up the environment and just confirm it is fine the style is not being apply? or should I change some code to include the style?

I go through the process on the GitHub developer.md quick start and apply the skin part to load the Vector. I didn't load the Event logging.

This is the local host view of wiki

Screenshot 2025-03-24 at 12.40.18.png (756×1 px, 99 KB)

P.S. I suspect the less engine is not compiling correctly

Hello, I set up the environment and just confirm it is fine the style is not being apply? or should I change some code to include the style?

I go through the process on the GitHub developer.md quick start and apply the skin part to load the Vector. I didn't load the Event logging.

This is the local host view of wiki

Screenshot 2025-03-24 at 12.40.18.png (756×1 px, 99 KB)

Styles should be applied indeed with the setup explained in DEVELOPERS.md. Are you seeing any errors on the JS console or the server logs (See DEVELOPERS.md#4-create-the-environment on how to see the logs from the server in docker). Perhaps you forgot to run composer update or docker compose exec mediawiki composer update ? Or you run it before pulling the skin code? Then you might need to run it again for the Vector dependencies to be satisfied. Let us know if this helps.

I see, this is the error.
I did the composer update and another command as well, but I will redo the process again.
In addition, I am still not being able to find the "most recent 1,000 edits", I want to be able to narrow down where can possibly be, can some explain what is the impact module? and where can the text possibly be?
Now I am looking at the languages/i18n/*.json files. I am also using the AI and the search function to find the text.

Screenshot 2025-03-25 at 10.33.58.png (354×740 px, 88 KB)

If it's not too late, I updated the suggested copy:

Wikipedia is created by a community of editors like you. You may be thanked by another contributor for an edit you’ve made, and you can thank others for their edits too. This metric will display a maximum of a 1,000 Thanks received, even if your actual total is higher.

I think that's slightly clearer than the previous wording.

In addition, I am still not being able to find the "most recent 1,000 edits", I want to be able to narrow down where can possibly be, can some explain what is the impact module? and where can the text possibly be?

It looks like we're using a variable for "1,000," which is likely why you're having trouble finding the exact string. Here’s the relevant code:

growthexperiments-homepage-impact-scores-thanks-info-text": "{{SITENAME}} is created by a community of editors like {{GENDER:|you}}. {{GENDER:|You}} may be thanked by other contributors for an edit {{GENDER:|you’ve}} made, and {{GENDER:|you}} can thank others for their edits too. The metric will only include thanks received for {{GENDER:|your}} most recent $2 edits.

I am also using the AI

Please do not.

I see, sorry I will avoid using it

I have find the message and change the message with the suggested statement. However, I have a problem to actually check how it actually looks like it on the browser.

Screenshot 2025-03-26 at 00.28.02.png (108×2 px, 89 KB)

Screenshot 2025-03-26 at 00.31.13.png (450×2 px, 165 KB)

From the previous comment I have done

docker compose down
docker compose up -d

And following update command from the Developer.md

Also I have done the process follow by the link to install GrowthExperience extension.
https://www.mediawiki.org/wiki/Extension:GrowthExperiments/developer_setup#Installation
After I have run the update again.
I am not sure the error is still asking for update.
This is the last update command and the output.

Screenshot 2025-03-26 at 00.34.22.png (770×1 px, 693 KB)

That screenshot was helpful:

Screenshot 2025-03-26 at 00.34.22.png (770×1 px, 693 KB)

You are trying to run a php-maintenance script on your host system, but that host system does not know about any of the databases that exist in the mediawiki docker containers.
If your local setup is based on docker, then you also need to run these PHP maintenance scripts, like update, with docker.

See the "Running commands" section in DEVELOPERS.md: https://gerrit.wikimedia.org/g/mediawiki/core/+/HEAD/DEVELOPERS.md#running-commands

Thank you for your feedback, I will work on it

Hello, my PHPUnit is running really slow, should I expected to be slow or it supposed to be fast?
This is the log
{F58949699}
Furthermore, when the code mention path/to/my/test/ where does it supposed to point?

ln addition, I finished edit the code, I just want to make sure it is also display on the browser as well. If this is not necessary please let me know.

Hello, my PHPUnit is running really slow, should I expected to be slow or it supposed to be fast?
This is the log
{F58949699}
Furthermore, when the code mention path/to/my/test/ where does it supposed to point?

Unfortunately, the screenshot for your log has not been attached to this task, and so I cannot see it. If you look at the right-hand column of this task, then you should be able to see this issue under the "Referenced Files" heading.

In general, there are *a lot* of PHPUnit tests, so running all of them takes quite a while. But I'm not sure if that is what you're seeing or if you are facing a separate issue.

ln addition, I finished edit the code, I just want to make sure it is also display on the browser as well. If this is not necessary please let me know.

Checking in the browser yourself is a good practice. The new copy should be visible on Special:Homepage and Special:Impact on your local wiki.

Thank you for your kind explanations. The reason I am asking about the Unit test is because after I run until 95% the unit test will stop, so I assume it didnt completed.
After using the running command you share with me from the GitHub there are two error left that I am figuring out.

First is CSS is not applied to this webpage and I am thinking maybe is the less compile error

Screenshot 2025-03-31 at 10.52.39.png (1×2 px, 500 KB)

Second it This Class "Elastica\Client" not found error, I did import from GitHub and also re-run the docker and the update command.
Screenshot 2025-03-31 at 10.50.56.png (1×2 px, 823 KB)

Hello, sorry for the slow update.
I have manage to solve all the issues, I will make sure the changes is correct and post here to confirm if it looks correct.
Can someone explain the process of commit? Like which branch and how should I make the pull request. If there is any link I read that will also be nice.

Capture-2025-04-20-082514.png (1×2 px, 281 KB)

Hello, sorry for the slow update.
I have manage to solve all the issues, I will make sure the changes is correct and post here to confirm if it looks correct.
Can someone explain the process of commit? Like which branch and how should I make the pull request. If there is any link I read that will also be nice.

Capture-2025-04-20-082514.png (1×2 px, 281 KB)

Sorry for taking some time to answer, this task fell off my radar for a bit.

I'm happy to hear that you've made progress! We use Gerrit to manage code reviews. You can read more about it in general here: https://www.mediawiki.org/wiki/Gerrit and in particular, there is an in-depth tutorial to get you started: https://www.mediawiki.org/wiki/Gerrit/Tutorial

Thank you for the link.
Yes, I will create the Gerrit account and read through the tutorial.

After this is it possible so have your suggestion about what next issue will you suggeste?

After this is it possible so have your suggestion about what next issue will you suggeste?

Sure, we can take a look and suggest another good first task after this one is complete.

To confirm my changes is correct I was checking on the webpage.
I need to login to check it and but I think I forgot the password since even I use the password I noted on my notes it said is invalid.
I send the email about changing the password request and they said I should received at my email address and I did not received it.
I am not sure why I cannot change my password now.

Screenshot 2025-05-14 at 1.09.17 AM.png (570×1 px, 69 KB)

In addition, I download the MySQL and MAMP in my computer, but it is not showing the database is not connected, I understand it is not necessary to be able to connect to the local data base this time but do I need to do something more than downloading the two system?

Screenshot 2025-05-14 at 1.16.07 AM.png (1×1 px, 507 KB)

I can't help you with the database connection, that is specific to your local environment. But I would expect that you can retrace the steps you did when creating your local development environment to resolve the issue.

As an alternative, you should be able to just register a new account in your local wiki, right? If that also does not work, then this would be hinting at something else being broken.

I think I figure out with the database now.
But I had another issue coming up and I saw other people in the mediawiki also encounter same issue.
When I run the php run.php -update.
It shows Process cache for 'en' should be set by now error. I tried to download "pecl install apcu" to solve the issue.
But I also find in the version PHP 8.4 it can't download the apcu properly now. What can I do to solve the problem?

Screenshot 2025-05-25 at 1.46.23 PM.png (1×1 px, 1 MB)

Sorry to hear you have run into a blocker here!
Moving out of current sprint and into Blocked.

I think I figure out with the database now.
But I had another issue coming up and I saw other people in the mediawiki also encounter same issue.
When I run the php run.php -update.
It shows Process cache for 'en' should be set by now error. I tried to download "pecl install apcu" to solve the issue.
But I also find in the version PHP 8.4 it can't download the apcu properly now. What can I do to solve the problem?

Screenshot 2025-05-25 at 1.46.23 PM.png (1×1 px, 1 MB)

I'm apologize, this task must have slipped through for me at some point.

PHP 8.4 is too new for us. Currently, MediaWiki is supported on 8.1 to 8.3, see https://www.mediawiki.org/wiki/Compatibility for more details.
I'm sorry that Mediawiki, and Growthexperiments, are sometimes quite tricky to set up. Though, I'm not sure what could have caused this particular error. Did you ever find a way around it?

Hello, I am glad to get the reply back. I am sorry for taking such a long time to complete this task.
I am just struggling with the tricky setup and the task by it self it is actually done.

I am not sure if I am allow to ask this, but is it possible to talk to you through zoom or some tool to figure this out and if I can submit my modification I would like to moving on to different task.

Lastly, I was working on it for couple time and I couldn't find the way out to solve the error. I had to postponed for a minutes so I will try to work on it again