Page MenuHomePhabricator

Refactor Device Analytics according to the new AQSAssist
Open, Needs TriagePublic

Description

Goal

Extract to aqsassist some repeated and common code that is present in all the services and refactor them to avoid code duplication as we already did with the functions we created to validate the parameters in the handlers.

About the Druid common code refactoring we will take the following into consideration:

The way to parameterize Druid queries that was implemented in AQS 1.0 (https://github.com/wikimedia/analytics-aqs/blob/master/sys/mediawiki-history-schemas.yaml) to parametrize Druid queries using a separate file
We'll start refactoring editor-analytics because its code is already done and we'll have the opportunity of using its unit and integration tests to test the refactored service.

Tasks

  • Refactor
  • QA test
  • Deploy

Event Timeline

EChukwukere-WMF removed a subscriber: Emeka-okechukwu.
EChukwukere-WMF added a subscriber: Emeka-okechukwu.

the user @Emeka-okechukwu is not part of our team

The changes here have been merged to prod. This has been tested through regression run for Device analytics and no issues found. All tests passed