Goal
Extract to aqsassist some repeated and common code that is present in all the services and refactor them to avoid code duplication as we already did with the functions we created to validate the parameters in the handlers.
About the Druid common code refactoring we will take the following into consideration:
- The way to parameterize Druid queries that was implemented in AQS 1.0 (https://github.com/wikimedia/analytics-aqs/blob/master/sys/mediawiki-history-schemas.yaml) to parametrize Druid queries using a separate file
- We'll start refactoring editor-analytics because its code is already done and we'll have the opportunity of using its unit and integration tests to test the refactored service.
Tasks
- Druid common code (edit and editor services)
- aqsassist review (merged) quick fix (merged)
- editor-analytics review using this approach (merged) quick fix (merged)
- edit-analytics (merged)
- All services common code (to be done in aqsassist) (merged)
- Common error messages (all services) (we could standardize them: lower case and no period at the end)
- Change not found message (remove references to the old documentation URL ("Please check https://wikimedia.org/api/rest_v1/?doc for more information . . . ")
- Common function to create built-in Problems (all services)
- Common logger functions (all services)
- Common error messages (all services) (we could standardize them: lower case and no period at the end)
- Refactor all services
Notes
An existing branch (https://gitlab.wikimedia.org/repos/generated-data-platform/aqs/aqsassist/-/tree/T343907?ref_type=heads) in aqsassist contains a first approach for the pending work of this task (All services common code). Just keep in mind that some work is already done there and we should keep working from that existing branch.