Page MenuHomePhabricator

Refactor Edit Analytics according to the new AQSAssist
Open, LowPublic2 Estimated Story Points

Description

Goal

Extract to aqsassist some repeated and common code that is present in all the services and refactor them to avoid code duplication as we already did with the functions we created to validate the parameters in the handlers.

About the Druid common code refactoring we will take the following into consideration:

The way to parameterize Druid queries that was implemented in AQS 1.0 (https://github.com/wikimedia/analytics-aqs/blob/master/sys/mediawiki-history-schemas.yaml) to parametrize Druid queries using a separate file
We'll start refactoring editor-analytics because its code is already done and we'll have the opportunity of using its unit and integration tests to test the refactored service.

Tasks

  • Refactor
  • QA test
  • Deploy

Event Timeline

JEbe-WMF set the point value for this task to 2.Mar 21 2024, 6:17 PM

Change #1013514 had a related patch set uploaded (by Jennifer Ebe; author: Jennifer Ebe):

[generated-data-platform/aqs/edit-analytics@main] Refactor Edit Analytics with AQS-Assist

https://gerrit.wikimedia.org/r/1013514

Change #1013514 merged by jenkins-bot:

[generated-data-platform/aqs/edit-analytics@main] Refactor Edit Analytics with AQS-Assist

https://gerrit.wikimedia.org/r/1013514

The changes here have been merged to prod. This has been tested through regression run for Edit analytics and no issues found. All tests passed