Use the CheckUserLookupUtils service in Special:CheckUser pager classes
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Mar 21 2024, 12:15 PM

Description

The CheckUserLookupUtils service was added in T360453, but not made use of in Special:CheckUser. This task is aimed at using this service over the existing static methods in the pager classes used by Special:CheckUser.

To do this, some of the existing unit tests that test that the query info methods need to be converted to integration tests. While the unit tests are faster, they were written in a fairly brittle way and writing them as an integration test will make the test more resilient.

Acceptance criteria

The CheckUserLookupUtils service should be used in AbstractCheckUserPager and it's subclasses.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T360622 here

Details

Subject	Repo	Branch	Lines +/-
Replace ::getIpConds and ::isValidRange with CheckUserLookupUtils	mediawiki/extensions/CheckUser	master	+62 -222
Replace AbstractCheckUserPager::getIndexName with CheckUserLookupUtils	mediawiki/extensions/CheckUser	master	+42 -68
Remove CheckUserGetIPsPagerTest::testGetCountForIPActionsPerTable	mediawiki/extensions/CheckUser	master	+0 -210
Delete AbstractCheckUserPager::getQueryInfo unit tests	mediawiki/extensions/CheckUser	master	+0 -221
Integration test the query info methods of the CheckUser pagers	mediawiki/extensions/CheckUser	master	+282 -3

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T341827 Add read new support to the CheckUser API
Resolved	Dreamy_Jazz	T360622 Use the CheckUserLookupUtils service in Special:CheckUser pager classes
Resolved	Dreamy_Jazz	T360453 Create the CheckUserLookupUtils service
		· · ·

Event Timeline

Dreamy_Jazz created this task.Mar 21 2024, 12:15 PM

Change 1013094 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Integration test the query info methods of the CheckUser pagers

https://gerrit.wikimedia.org/r/1013094

gerritbot added a project: Patch-For-Review.Mar 21 2024, 12:15 PM

Dreamy_Jazz added a subtask: T360453: Create the CheckUserLookupUtils service.Mar 21 2024, 12:50 PM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

Change 1013303 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserGetIPsPagerTest::testGetCountForIPActionsPerTable

https://gerrit.wikimedia.org/r/1013303

Change 1013306 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Delete AbstractCheckUserPager::getQueryInfo unit tests

https://gerrit.wikimedia.org/r/1013306

Change 1013313 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Replace AbstractCheckUserPager::getIndexName with CheckUserLookupUtils

https://gerrit.wikimedia.org/r/1013313

Change #1013330 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Replace ::getIpConds and ::isValidRange with CheckUserLookupUtils

https://gerrit.wikimedia.org/r/1013330

Dreamy_Jazz claimed this task.Mar 21 2024, 3:23 PM

Dreamy_Jazz set the point value for this task to 3.

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 21 2024, 6:18 PM

Change #1013094 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Integration test the query info methods of the CheckUser pagers

https://gerrit.wikimedia.org/r/1013094

Change #1013303 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserGetIPsPagerTest::testGetCountForIPActionsPerTable

https://gerrit.wikimedia.org/r/1013303

Change #1013306 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Delete AbstractCheckUserPager::getQueryInfo unit tests

https://gerrit.wikimedia.org/r/1013306

Change #1013313 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace AbstractCheckUserPager::getIndexName with CheckUserLookupUtils

https://gerrit.wikimedia.org/r/1013313

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 21 2024, 8:00 PM

Tchanders mentioned this in T360453: Create the CheckUserLookupUtils service.Mar 21 2024, 8:25 PM

Umherirrender mentioned this in T358940: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes.Mar 21 2024, 9:39 PM

Dreamy_Jazz closed subtask T360453: Create the CheckUserLookupUtils service as Resolved.Mar 21 2024, 9:59 PM

Change #1013330 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace ::getIpConds and ::isValidRange with CheckUserLookupUtils

https://gerrit.wikimedia.org/r/1013330

In this ticket there should have been no change to the functionality of Special:CheckUser. As such, I would suggest verifying that no changes have been observed.

@Dreamy_Jazz I did not come across any changes in functionality as seen in some of the screenshots below. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (2e857b0) 15:04, 25 March 2024; CheckUser: 2.5 (05418d9) 07:35, 25 March 2024
OS: macOS Sonoma 14.4
Browser: Chrome 122, Firefox 123, Safari 17.3, Edge 122
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
Special:Checkuser
https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog#