Page MenuHomePhabricator

Subscription state is not updated on the page after saving a reply, error appears: "jQuery.Deferred exception: element is undefined"
Closed, ResolvedPublic

Description

I noticed that, after I replied, the interface wasn't updated to show that I have become subscribed to the topic (although I was, and refreshing the page shows it correctly). The next time it happened I looked in the browser console, and found:

jQuery.Deferred exception: element is undefined 
getSubscribedStateFromElement@https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector-2022&version=k3kzd:35:805
updateSubscriptionStates@https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector-2022&version=k3kzd:42:635
updateAutoSubscriptionStates@https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector-2022&version=k3kzd:44:742
controller.js/init/<@https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector-2022&version=k3kzd:15:674
mightThrow@https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector-2022&version=k3kzd:360:648
Deferred/then/resolve/</process<@https://en.wikipedia.org/w/load.php?lang=en&modules=ext.discussionTools.init%7Cjquery%2Coojs-ui-core&skin=vector-2022&version=k3kzd:361:309
 undefined jquery.js:3783:17

Event Timeline

Maybe. I also wonder if T359751 is related. I haven't looked into it, I just want to make sure it's not forgotten.

Change #1014528 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014528

Change #1014528 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014528

Change #1014457 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.24] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014457

Change #1014457 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.24] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014457

Ryasmeen claimed this task.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.