Page MenuHomePhabricator

Creating the first topic of a new talk page should still automatically subscribe me
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue:

  • Ensure Automatically subscribe to topics is enabled in your preferences.
  • Visit an existing page, which has no talk page (i.e. “Talk” tab is a red link) e.g. test:Danmark
  • Click “Talk” tab: you’re going at ?title=Talk:XXXX&action=edit&redlink=1
  • Click Start a discussion button.
  • Type a subject, a topic and post it.

What happens?
You are not automatically subscribed to the topic you just created.

What should have happened instead?
You should be automatically subscribed to the topic you just created.

Event Timeline

Could you please guide me regarding the same, I want to do a contribution in this task as a beginner.

The same? You’ll find a starting guide and DiscussionTools repository (Phabricator mirror). Reviewing sister tasks (e.g. T284836) may also help you to locate the related code.

I tested this locally just now and I can't reproduce the problem. If you still see it, it would be helpful if you could link to the specific pages and topics where it didn't work as expected.

Also, please check whether the automatic subscription status appears after you refresh the page – Ed and I were wondering in T360942/T360863 whether the problem is that the subscription is added, but the page is not updated to show it.

Change #1014528 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014528

Change #1014528 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014528

Change #1014457 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.24] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014457

Change #1014457 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.24] topicsubscriptions.js: No longer assume both buttons and links exist in DOM

https://gerrit.wikimedia.org/r/1014457

I tested this locally just now and I can't reproduce the problem. If you still see it, it would be helpful if you could link to the specific pages and topics where it didn't work as expected.

Also, please check whether the automatic subscription status appears after you refresh the page – Ed and I were wondering in T360942/T360863 whether the problem is that the subscription is added, but the page is not updated to show it.

I just reproduced at test:Talk:Danmark. Refreshing the page does not change the subscribed status.
In real cases, I met this issue at:

I also reproduced today when testing the backport at https://test.wikipedia.org/wiki/Talk:2024-03-26_test. So we fixed the frontend, but the backend is still broken. However, I can't reproduce locally.

I can reproduce when I set $wgDiscussionToolsAutoTopicSubEditor = 'discussiontoolsapi';, which is the value we use in production (it was supposed to be changed in T290778, but that hasn't happened yet).

It turns out I broke it last June while working on support for temporary account (IP masking) :/ (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/929408)

Change #1014639 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix autosubscribe on new pages with $wgDiscussionToolsAutoTopicSubEditor = 'discussiontoolsapi'

https://gerrit.wikimedia.org/r/1014639

Change #1014639 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix autosubscribe on new pages with $wgDiscussionToolsAutoTopicSubEditor = 'discussiontoolsapi'

https://gerrit.wikimedia.org/r/1014639

I am subscribed automatically as expected:

Screenshot 2024-04-03 at 11.02.36.png (884×1 px, 71 KB)