Patch-For-Review tags are not being removed from tasks by @Maintenance_bot any more, for example on https://phabricator.wikimedia.org/T359751. (I noticed this on a few other tasks in the last couple of days, but I don't have the links handy.)
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
Looks like it's working to me. The above task shouldn't have patch-for-review removed since it has an open patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/1014639)
Comment Actions
Looking at the activities of the bot, it does remove the tag: https://phabricator.wikimedia.org/p/Maintenance_bot/
Comment Actions
That patch has been merged now (4.5 hours ago) but https://phabricator.wikimedia.org/T359751 still has the tag. @Maintenance_bot has handled other tasks in the meantime, but not this one. I'm glad to see that it's not completely broken, but it seems that something is off, or I don't understand how it works.
Comment Actions
There are many cases that the bot errs on the side of not removing the tag, e.g. there has been many cases that people added the tag because of github PR and as such the bot avoids touching any ticket that has link to a github PR. Removal has never been only the job of the bot (many people did that work before the bot started), the idea is that the bot takes care of the majority of the work and people take care of the edge cases. I can spend some time to figure out what exactly tripped the bot not to remove the tag but I'm not sure if it's worth the effort.