Page MenuHomePhabricator
Create Task
Maniphest T361212

Images in reference drawer don't lazy load
Open, LowPublic
Actions

Description

For example, Math formulae. All that is shown is the grey placeholder:

image.png (454×483 px, 45 KB)

If you scroll to the references section the reference now renders (as black on black because of T129054, but if you disable the black background it is there)

image.png (454×483 px, 47 KB)
image.png (454×483 px, 47 KB)

Details

SubjectRepoBranchLines +/-
Trigger image lazy load when drawer opensmediawiki/extensions/MobileFrontendmaster+16 -4
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 28 2024, 11:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2024, 11:28 AM
gerritbot added a comment.Mar 28 2024, 11:36 AM

Change #1015291 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Trigger image lazy load when drawer opens

https://gerrit.wikimedia.org/r/1015291

gerritbot added a project: Patch-For-Review.Mar 28 2024, 11:36 AM
Esanders updated the task description. (Show Details)Mar 28 2024, 11:37 AM
Esanders mentioned this in T129054: Math formulas can be unreadable in references in mobile view.Mar 28 2024, 3:41 PM
Jdlrobson added a project: Web-Team-Backlog.Mon, Apr 1, 12:09 AM
Jdlrobson subscribed.Mon, Apr 1, 11:06 PM

My understanding is Math images might be going away (T353000). Not sure if this is the only use case though.

Esanders added a comment.Tue, Apr 2, 8:31 PM

It is possible to include any image in a reference using [[File: syntax, so this should work regardless of what happens with Math rendering.

Jdlrobson added a comment.Wed, Apr 3, 1:31 AM

I know it's possible, I just seldom see it happen so I'm wondering what % of articles this bug fixes.

ovasileva triaged this task as Low priority.Thu, Apr 4, 8:28 AM
ovasileva moved this task from Incoming to Groomed on the Web-Team-Backlog board.
ovasileva subscribed.
In T361212#9682642, @Jdlrobson wrote:

I know it's possible, I just seldom see it happen so I'm wondering what % of articles this bug fixes.

Any thoughts on whether we have this data? Marking as low for now

Jdlrobson assigned this task to Esanders.Mon, Apr 15, 3:09 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 2); removed Web-Team-Backlog.

Adding to sprint 2 for consideration as there is a patch open from Ed.

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q4 Sprint 2).Tue, Apr 23, 5:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL