[Bug] Minerva - History page is not linked to from diffs for anonymous users
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 1 2024, 10:03 PM

Description

Steps to reproduce

As anonymous user go to https://en.m.wikipedia.org/w/index.php?title=History_of_Norwich_City_F.C.&diff=845690345&diffonly=1

Expected results

Link to history

Actual results

No link to history

Environments observed

Browser version:
OS version:
Device model:
Device language:

Check any additional observations

Observed on the beta cluster wiki
Observed on a production wiki
Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

Stack trace

Console output

Task Description:

QA Results - PROD

AC	Status	Details
1	✅	T361526#9807596 this is a pass per T361526#9808963

Details

	Subject	Repo	Branch	Lines +/-
	Show history link on diff page for anonymous users	mediawiki/skins/MinervaNeue	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T363373: Verify 1.43.0-wmf.4 deployment
T201228: Make it possible to reach the page history from mobile diff
Mentioned Here: T363916: [bug] History link doesn't show on main page diffs

Event Timeline

Jdlrobson triaged this task as Medium priority.Apr 1 2024, 10:03 PM

Jdlrobson created this task.

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 1 2024, 10:03 PM

Jdlrobson updated the task description. (Show Details)Apr 1 2024, 10:03 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T201228: Make it possible to reach the page history from mobile diff.

Change #1016015 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Show history link on diff page for anonymous users

https://gerrit.wikimedia.org/r/1016015

gerritbot added a project: Patch-For-Review.Apr 1 2024, 10:05 PM

Jdlrobson moved this task from Backlog to Remove MobileFrontend special pages on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Apr 24 2024, 3:11 PM

Change #1016015 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Show history link on diff page for anonymous users

https://gerrit.wikimedia.org/r/1016015

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 1 2024, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 1 2024, 2:31 PM

Thanks @jsn.sherman . I checked this on beta cluster and it works well. We'll QA this one in production. Opened up T363916 for the main page issue.

Edtadros mentioned this in T363373: Verify 1.43.0-wmf.4 deployment.May 15 2024, 10:51 PM

@Jdlrobson @Edtadros Is this the Link to history that you are talking about?

Test Result - PROD

Status: ❓NMI
Environment: PROD
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

❓ AC1: As an anonymous user go to https://en.m.wikipedia.org/w/index.php?title=History_of_Norwich_City_F.C.&diff=845690345&diffonly=1

2024-05-16_20-31-52 (1).gif (1×2 px, 1 MB)

GMikesell-WMF updated the task description. (Show Details)May 17 2024, 3:35 AM

Yep that's the link we were looking for !

Edtadros updated the task description. (Show Details)May 21 2024, 1:06 AM

[Bug] Minerva - History page is not linked to from diffs for anonymous usersClosed, ResolvedPublicBUG REPORTActions