Field: Add a CSS class to differentiate between a `.cdx-field` and a fieldset
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Tue, Apr 2, 4:25 AM

Description

Background

With higher complex forms, we need some kind of styling hook for fieldsets in contrast to only .cdx-field as we will need to differentiate between them.
Relying on fieldset element selector as qualifier is against our approach to be as DOM-element independent elsewhere.

Goal

Add additional selector.

Open questions

Deciding if we're going for .cdx-fieldset additionally to .cdx-field or for a different solution
- Decision: We add cdx-field--is-fieldset to the Field class.

Acceptance criteria

Add cdx-field--is-fieldset to Codex Field when isFieldset is true

Details

Subject	Repo	Branch	Lines +/-
Update Codex from 1.3.6 to 1.4.0	mediawiki/core	master	+190 -114
Field: Add additional class if it's a `fieldset`	design/codex	main	+4 -3
CodexHTMLForm: Add specific CSS class to fieldset	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T359022: CodexHTMLForm: Add spacing between adjacent CheckboxFields

Event Timeline

Volker_E created this task.Tue, Apr 2, 4:25 AM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptTue, Apr 2, 4:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think this should be in our sprint as a simple and useful addition to the CodexHTMLForm in connection with Multiblocks. Such a selector could actually already be useful in T359022: CodexHTMLForm: Add spacing between adjacent CheckboxFields.

Change #1016074 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Field: Add additional class if it's a `fieldset`

https://gerrit.wikimedia.org/r/1016074

gerritbot added a project: Patch-For-Review.Tue, Apr 2, 4:29 AM