Page MenuHomePhabricator

Field: Add a CSS class to differentiate between a `.cdx-field` and a fieldset
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

With higher complex forms, we need some kind of styling hook for fieldsets in contrast to only .cdx-field as we will need to differentiate between them.
Relying on fieldset element selector as qualifier is against our approach to be as DOM-element independent elsewhere.

Goal

Add additional selector.

Open questions

  • Deciding if we're going for .cdx-fieldset additionally to .cdx-field or for a different solution
    • Decision: We add cdx-field--is-fieldset to the Field class.

Acceptance criteria

  • Add cdx-field--is-fieldset to Codex Field when isFieldset is true

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think this should be in our sprint as a simple and useful addition to the CodexHTMLForm in connection with Multiblocks. Such a selector could actually already be useful in T359022: CodexHTMLForm: Add spacing between adjacent CheckboxFields.

Change #1016074 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Field: Add additional class if it's a `fieldset`

https://gerrit.wikimedia.org/r/1016074

CCiufo-WMF subscribed.

@Volker_E can you put a point value on this?

Volker_E set the point value for this task to 2.Apr 2 2024, 11:36 PM

Change #1017178 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] CodexHTMLForm: Add specific CSS class to fieldset

https://gerrit.wikimedia.org/r/1017178

Change #1016074 merged by jenkins-bot:

[design/codex@main] Field: Add additional class if it's a `fieldset`

https://gerrit.wikimedia.org/r/1016074

Change #1020918 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

Change #1020918 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918