Maniphest T361910

WP detect links fail on some wikipedia urls
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hueitan
	Apr 5 2024, 7:43 AM

Description

the detect links work when the language is given, but it doesn't work for the following case

https://wikipedia.org/wiki/Cat, this doesn't convert to preview link
https://m.wikipedia.org/wiki/Cat, this convert a fail preview link
https://en.m.wikipedia.org/wiki/Cat, this works fine.

the current accepted link regex is here, these links expecting to have a english preview link with title cat.

this should also accept (language with dash -), for example https://be-tarask.wikipedia.org/wiki/Фрыдрых Шылер

QA Results - WordPress Dev

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T361910 here

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		hueitan	T361910 WP detect links fail on some wikipedia urls
		Invalid	BUG REPORT	None	T366560 detect links doesn't work for the article title starting with &

Event Timeline

hueitan created this task.Apr 5 2024, 7:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2024, 7:43 AM

hueitan renamed this task from WP detect links fail on some wikipedia url to WP detect links fail on some wikipedia urls.Apr 5 2024, 7:43 AM

hueitan updated the task description. (Show Details)

hueitan updated the task description. (Show Details)Apr 5 2024, 7:46 AM

hueitan claimed this task.Apr 5 2024, 8:47 AM

hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

• PWaigi-WMF triaged this task as Medium priority.Apr 5 2024, 5:11 PM

hueitan updated the task description. (Show Details)Apr 16 2024, 6:34 AM

https://github.com/wikimedia/wikipedia-preview/pull/194

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Apr 16 2024, 12:28 PM

@hueitan All preview links work with the different case scenarios from each test link below. I will move this to Design Sign-off. Thanks for all your work!

Status: ✅PASS
Environment: WordPress Dev- 6.5.2; Wikipedia Preview version 1.10.0 (38ae85e)
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 124, Safari 17.4
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://wikipedia.org/wiki/Cat
https://m.wikipedia.org/wiki/Cat
https://en.m.wikipedia.org/wiki/Cat
https://be-tarask.wikipedia.org/wiki/Фрыдрых
https://zh-min-nan.wikipedia.org/wiki/Heng-ta%CC%8Dt_Hoat-ti%C4%81n-chhi%C3%BA%E2%81%BF

✅AC1: https://phabricator.wikimedia.org/T361910

Chrome	Safari	Firefox

GMikesell-WMF updated the task description. (Show Details)Apr 23 2024, 5:25 PM

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

@GMikesell-WMF I am wondering if we have to test it for short URLs too? e.g. https://w.wiki/Wz6 or URLs formed using the page id such as this - https://en.wikipedia.org/?curid=6678

In T361910#9760410, @SGautam_WMF wrote:

@GMikesell-WMF I am wondering if we have to test it for short URLs too? e.g. https://w.wiki/Wz6 or URLs formed using the page id such as this - https://en.wikipedia.org/?curid=6678

These two cases are stretching the boundaries of the detect feature since you cannot really tell from looking at the URL, you have to actually request them to know what they resolve to.

I would call them out of scope in this task but certainly valid ideas for the future if we have any indications that it's a valid use case for some users.

In T361910#9760944, @SBisson wrote:

In T361910#9760410, @SGautam_WMF wrote:

@GMikesell-WMF I am wondering if we have to test it for short URLs too? e.g. https://w.wiki/Wz6 or URLs formed using the page id such as this - https://en.wikipedia.org/?curid=6678

These two cases are stretching the boundaries of the detect feature since you cannot really tell from looking at the URL, you have to actually request them to know what they resolve to.

I would call them out of scope in this task but certainly valid ideas for the future if we have any indications that it's a valid use case for some users.