Page MenuHomePhabricator

The page gets unreviewed when moved to a new address
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

On Polish Wikisource.
Move a page (Page: - namespace or main) to a new location
https://pl.wikisource.org/w/index.php?title=Strona:Jerzy_Bandrowski_-_Krwawa_chmura.djvu/162&action=history

Leaving a redirect or without does not matter.

What happens?:
Now the page shows up as unreviewed even if the last status was reviewed. The flag of the user who performs the task does not matter (editor/sysop/bot).

What should have happened instead?:

The page should stay reviewed.

Other information (browser name/version, screenshots, etc.):

It seems to be connected to the issue T361166

Event Timeline

This problem exists also with moving pages in the main namespace that are unrelated to ProofreadPage

Wargo added subscribers: matmarex, Wargo.

Moving maybeMakeEditReviewed from RevisionFromEditComplete to PageSaveComplete in 8d1c5f81c976857fefaa30af69a536a2f27c2f3f is the cause.

Yes, probably my fault, that change broke a few other things :(

That's the same as T361940 which already has a connected patch to revert the change.

Change #1017376 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/FlaggedRevs@master] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017376

Change #1017376 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017376

Change #1017890 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.25] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017890

Change #1017890 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.42.0-wmf.25] Revert "Mark all autoreviewed edits in PageSaveComplete hook"

https://gerrit.wikimedia.org/r/1017890

Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:09:24Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:11:36Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-08T20:25:49Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1017890|Revert "Mark all autoreviewed edits in PageSaveComplete hook" (T361918 T361940 T361960)]] (duration: 16m 25s)