Page MenuHomePhabricator

Golang-based Cassandra clients do not perform TLS host verification
Open, MediumPublic

Description

During work to migrate Cassandra to PKI, @elukey discovered that golang Cassandra clients do not validate any metadata of the TLS server certs (expiry date, chain, hostname, etc..). This seems to be true of at least the new AQS 2.0 services, image suggestions, and Kask (sessionstore & echostore).

Details

TitleReferenceAuthorSource BranchDest Branch
Configure verification of server certificate chain and hostnamerepos/mediawiki/services/kask!2eevansenable_host_verificationmain
Customize query in GitLab

Event Timeline

Eevans triaged this task as Medium priority.Fri, Apr 5, 6:24 PM
Eevans created this task.

@Eevans medium is going to mean that it will likely only make it into a sprint at the end of this quarter. Is that ok or is this a risk?

@Eevans medium is going to mean that it will likely only make it into a sprint at the end of this quarter. Is that ok or is this a risk?

It's been like this all along, so waiting until the end of the quarter is probably OK.

We've encountered a problem enabling verification for gocql-based clients (see: T352647#9715110). We'll need to implement a custom HostDialer for Cassandra-connecting golang services before this work can continue.

Eevans renamed this task from (some?) golang-based Cassandra clients do not perform TLS host verification to Golang-based Cassandra clients do not perform TLS host verification.Tue, Apr 16, 2:55 PM
Eevans moved this task from Backlog to In-Progress on the Cassandra board.

@Eevans Please let us know when this is unblocked.