Page MenuHomePhabricator
Create Task
Maniphest T361995

Remove usage of JsonBodyValidator from extensions
Closed, ResolvedPublic
Actions

Description

Extensions should use the new default validation mechanism for JSON request bodies, instead of using JsonBodyValidator.

WMF Extensions to fix:

  • ReadingLists
  • CheckUser
  • GrowthExperiments
  • CampaignEvents - T365526
  • WikimediaCampaignEvents - T365527
  • SecurePoll
  • FlaggedRevs
  • IPInfo
  • ReportIncident
  • Wikibase (TypeValidatingJsonBodyValidator extends JsonBodyValidator) - Picked up by Wikibase team, see T363084

Affected 3rd party extensions:
Moved to T365757

Details

SubjectRepoBranchLines +/-
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/CheckUsermaster+75 -157
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/SecurePollmaster+36 -13
Use new body validation in the handlersmediawiki/extensions/ReportIncidentmaster+29 -169
Use new body validation in the handlersmediawiki/extensions/CampaignEventsmaster+48 -111
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/IPInfomaster+88 -45
Use new body validation in the handlersmediawiki/extensions/GrowthExperimentsmaster+37 -43
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/CampaignEventsmaster+32 -39
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/FlaggedRevsmaster+13 -30
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Apr 6 2024, 9:52 AM
gerritbot added a comment.Apr 6 2024, 9:52 AM

Change #1017338 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] EXPERIMENT: Hard-deprecate getBodyValidator

https://gerrit.wikimedia.org/r/1017338

gerritbot added a project: Patch-For-Review.Apr 6 2024, 9:52 AM
daniel updated the task description. (Show Details)Apr 6 2024, 9:59 AM
daniel updated the task description. (Show Details)
gerritbot added a comment.Apr 17 2024, 2:45 PM

Change #1020715 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/FlaggedRevs@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1020715

daniel changed the task status from Open to In Progress.Apr 17 2024, 4:25 PM
daniel assigned this task to Atieno.
daniel triaged this task as High priority.
daniel moved this task from Incoming (Needs Triage) to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
daniel moved this task from Backlog (Triaged and Ready) to In Progress on the MW-Interfaces-Team board.
gerritbot added a comment.Apr 18 2024, 4:49 PM

Change #1020715 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1020715

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 18 2024, 5:00 PM
WMDE-leszek mentioned this in T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API.Apr 22 2024, 9:19 AM
daniel updated the task description. (Show Details)Apr 23 2024, 9:13 AM
gerritbot added a comment.Apr 24 2024, 10:54 AM

Change #1023826 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/CampaignEvents@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1023826

gerritbot added a comment.Apr 30 2024, 2:58 PM

Change #1025798 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/GrowthExperiments@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1025798

gerritbot added a comment.Apr 30 2024, 3:08 PM

Change #1025799 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/SecurePoll@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1025799

daniel reassigned this task from Atieno to • codebug.May 2 2024, 3:13 PM
daniel reassigned this task from • codebug to Atieno.
gerritbot added a comment.May 3 2024, 10:35 AM

Change #1026825 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/IPInfo@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1026825

gerritbot added a comment.May 6 2024, 4:37 PM

Change #1023826 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1023826

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).May 6 2024, 5:00 PM
gerritbot added a comment.May 7 2024, 10:38 AM

Change #1025798 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1025798

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.5; 2024-05-14); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 7 2024, 11:00 AM
gerritbot added a comment.May 16 2024, 10:59 AM

Change #1032419 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/CampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1032419

gerritbot added a comment.May 16 2024, 3:26 PM

Change #1026825 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1026825

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 16 2024, 4:00 PM
Atieno updated the task description. (Show Details)May 20 2024, 11:02 AM
Atieno updated the task description. (Show Details)May 20 2024, 11:05 AM
• codebug updated the task description. (Show Details)May 20 2024, 12:31 PM
gerritbot added a comment.May 20 2024, 3:45 PM

Change #1034110 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/WikimediaCampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1034110

Atieno added a comment.May 21 2024, 2:14 PM

Assigning this to @codebug as she will be closing this ticket out for the remaining Extensions

Atieno reassigned this task from Atieno to • codebug.May 21 2024, 2:14 PM
Daimona mentioned this in T365526: Remove usage of JsonBodyValidator from CampaignEvents.May 21 2024, 7:55 PM
Daimona added a subtask: T365526: Remove usage of JsonBodyValidator from CampaignEvents.
Daimona updated the task description. (Show Details)
Daimona mentioned this in T365527: Remove usage of JsonBodyValidator from WikimediaCampaignEvents.May 21 2024, 8:05 PM
Daimona added a subtask: T365527: Remove usage of JsonBodyValidator from WikimediaCampaignEvents.
Daimona updated the task description. (Show Details)
gerritbot added a comment.May 22 2024, 7:34 PM

Change #1032419 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/CampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1032419

gerritbot added a comment.May 22 2024, 7:39 PM

Change #1034110 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/WikimediaCampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1034110

gerritbot added a comment.May 22 2024, 11:37 PM

Change #1035063 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/ReportIncident@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1035063

gerritbot added a comment.May 23 2024, 10:43 AM

Change #1035355 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/CheckUser@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1035355

gerritbot added a comment.May 23 2024, 12:03 PM

Change #1032419 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1032419

• codebug updated the task description. (Show Details)May 23 2024, 12:29 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 23 2024, 1:00 PM
• codebug updated the task description. (Show Details)May 23 2024, 2:11 PM
vaughnwalters closed subtask T365527: Remove usage of JsonBodyValidator from WikimediaCampaignEvents as Resolved.May 23 2024, 9:52 PM
daniel updated the task description. (Show Details)May 28 2024, 8:46 AM
daniel updated the task description. (Show Details)
vaughnwalters closed subtask T365526: Remove usage of JsonBodyValidator from CampaignEvents as Resolved.May 28 2024, 8:35 PM
gerritbot added a comment.Jun 3 2024, 5:09 PM

Change #1035063 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1035063

• codebug mentioned this in rEREIa0a6788bbc72: Use new body validation in the handlers.Jun 3 2024, 5:38 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Jun 3 2024, 6:00 PM
gerritbot added a comment.Jun 4 2024, 2:43 PM

Change #1025799 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1025799

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Jun 4 2024, 3:00 PM
gerritbot added a comment.Jun 4 2024, 7:23 PM

Change #1035355 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1035355

• codebug updated the task description. (Show Details)Jun 5 2024, 8:43 AM
• FJoseph-WMF closed this task as Resolved.Jun 6 2024, 2:46 PM
• FJoseph-WMF moved this task from In Progress to Done on the MW-Interfaces-Team board.
• FJoseph-WMF updated the task description. (Show Details)
daniel removed a subtask: T367394: REST: Stop using getParamSettings for body parameters.Jun 13 2024, 10:33 AM
daniel updated the task description. (Show Details)Jun 13 2024, 11:00 AM
FGoodwin changed the status of subtask T365757: Help remove usage of JsonBodyValidator from 3rd party extensions from Open to In Progress.Jun 14 2024, 3:55 PM
daniel updated the task description. (Show Details)Jun 21 2024, 8:13 AM
FGoodwin closed subtask T365757: Help remove usage of JsonBodyValidator from 3rd party extensions as Resolved.Jun 21 2024, 7:11 PM
Ollie.Shotton_WMDE closed subtask T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API as Resolved.Jul 9 2024, 9:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits