Page MenuHomePhabricator
Create Task
Maniphest T361995

Remove usage of JsonBodyValidator from extensions
Open, In Progress, HighPublic
Actions

Description

Extensions should use the new default validation mechanism for JSON request bodies, instead of using JsonBodyValidator.

WMF Extensions to fix:

  • ReadingLists
  • CheckUser
  • GrowthExperiments
  • CampaignEvents
  • WikimediaCampaignEvents
  • SecurePoll
  • FlaggedRevs
  • IPInfo
  • ReportIncident
  • Wikibase (TypeValidatingJsonBodyValidator extends JsonBodyValidator)

Affected 3rd party extesions:

  • TuleapWikiFarm
  • ProfessionalWiki/WikibaseRDF
  • Workflows
  • Adiutor
  • BlueSpiceExtendedSearch
  • Checklists
  • ContentStabilization
  • MenuEditor

Details

SubjectRepoBranchLines +/-
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/IPInfomaster+1 -11
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/CampaignEventsmaster+32 -39
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/SecurePollmaster+0 -13
Use new body validation in the handlersmediawiki/extensions/GrowthExperimentsmaster+37 -43
Remove usage of JsonBodyValidator from extensionsmediawiki/extensions/FlaggedRevsmaster+13 -30
EXPERIMENT: Hard-deprecate getBodyValidatormediawiki/coremaster+42 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Sat, Apr 6, 9:52 AM
gerritbot added a comment.Sat, Apr 6, 9:52 AM

Change #1017338 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] EXPERIMENT: Hard-deprecate getBodyValidator

https://gerrit.wikimedia.org/r/1017338

gerritbot added a project: Patch-For-Review.Sat, Apr 6, 9:52 AM
daniel updated the task description. (Show Details)Sat, Apr 6, 9:59 AM
daniel updated the task description. (Show Details)
gerritbot added a comment.Wed, Apr 17, 2:45 PM

Change #1020715 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/FlaggedRevs@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1020715

daniel changed the task status from Open to In Progress.Wed, Apr 17, 4:25 PM
daniel assigned this task to Atieno.
daniel triaged this task as High priority.
daniel moved this task from Incoming (Needs Triage) to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
daniel moved this task from Backlog (Triaged and Ready) to In Progress on the MW-Interfaces-Team board.
gerritbot added a comment.Thu, Apr 18, 4:49 PM

Change #1020715 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1020715

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Thu, Apr 18, 5:00 PM
WMDE-leszek mentioned this in T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API.Mon, Apr 22, 9:19 AM
daniel updated the task description. (Show Details)Tue, Apr 23, 9:13 AM
gerritbot added a comment.Wed, Apr 24, 10:54 AM

Change #1023826 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/CampaignEvents@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1023826

gerritbot added a comment.Tue, Apr 30, 2:58 PM

Change #1025798 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/GrowthExperiments@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1025798

gerritbot added a comment.Tue, Apr 30, 3:08 PM

Change #1025799 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/SecurePoll@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1025799

daniel reassigned this task from Atieno to codebug.Thu, May 2, 3:13 PM
daniel reassigned this task from codebug to Atieno.
gerritbot added a comment.Fri, May 3, 10:35 AM

Change #1026825 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/IPInfo@master] Remove usage of JsonBodyValidator from extensions

https://gerrit.wikimedia.org/r/1026825

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL