Page MenuHomePhabricator
Create Task
Maniphest T362001

[ES-M2]: Updating EntitySchema to make use of the new mechanism
Open, Needs TriagePublic
Actions

Description

To make use of the new mechanism implemented in the patch from the Product Platform team, we need to make some changes on the EntitySchema side.

When parsing statement/qualifier/reference values, Wikibase will take into account the corresponding Property's data type and not only the value type. A data type specific value parser can be registered with the data type definition (here: EntitySchema). This will allow serialized EntitySchema values to contain type: wikibase-entityid without being parsed as an EntityIdValue.

The changes that are required are:

  • New value type
  • New parser/deserializer
  • Adjust validators

Acceptance criteria

  • Users are able to create an EntitySchema data value type statement
  • Users are able to load an EntitySchema data value type statement and it is linked to the EntitySchema

To create a statement using the API sandbox, use the wbsetclaim action, let the API sandbox fill in the token parameter, and set the claim to JSON similar to this:

{"type":"statement","mainsnak":{"snaktype":"value","property":"P592","datavalue":{"type":"wikibase-entityid","value":{"id":"E1"}}},"id":"P592$6dcf36c9-238a-435b-8ead-6fd1915b8548","rank":"normal"}

Where P592 is a property with data type EntitySchema, 6dcf36c9-238a-435b-8ead-6fd1915b8548 is a random UUID (you can get a fresh one from cat /proc/sys/kernel/random/uuid), and E1 is the ID of an existing EntitySchema.

Details

SubjectRepoBranchLines +/-
Add formatting for EntitySchema valuesmediawiki/extensions/EntitySchemamaster+283 -234
Register entity schema data type for clientsmediawiki/extensions/EntitySchemamaster+65 -13
Use custom entity schema value parsermediawiki/extensions/EntitySchemamaster+317 -97
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arian_Bozorg created this task.Sat, Apr 6, 1:29 PM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Tue, Apr 9, 2:14 PM
Arian_Bozorg updated the task description. (Show Details)Wed, Apr 10, 11:10 AM
Arian_Bozorg added a subscriber: • Lucas_Werkmeister_WMDE.

@Lucas_Werkmeister_WMDE can you please add the info for the API sandbox?

Arian_Bozorg moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Wed, Apr 10, 12:06 PM
• Lucas_Werkmeister_WMDE updated the task description. (Show Details)Wed, Apr 10, 12:53 PM
• Lucas_Werkmeister_WMDE added a comment.Fri, Apr 12, 12:23 PM

To make use of the new mechanism implemented in the patch from the Product Platform team

I’m trying to figure out what the status of that mechanism is… the relevant tasks seem to be T354778 and T359421, and the big change adding the new mechanism (corresponding to the prototype changes in T355144) seems to be Wire up DataTypeAwareSnakDeserializer.

ArthurTaylor claimed this task.Fri, Apr 19, 11:34 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Fri, Apr 19, 11:37 AM

Change #994206 had a related patch set uploaded (by Arthur taylor; author: Jakob):

[mediawiki/extensions/EntitySchema@master] Use custom entity schema value parser

https://gerrit.wikimedia.org/r/994206

gerritbot added a project: Patch-For-Review.Fri, Apr 19, 11:37 AM

Change #1007655 had a related patch set uploaded (by Arthur taylor; author: Jakob):

[mediawiki/extensions/EntitySchema@master] Register entity schema data type for clients

https://gerrit.wikimedia.org/r/1007655

ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Mon, Apr 22, 7:19 AM
gerritbot added a comment.Mon, Apr 22, 12:26 PM

Change #1023082 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Add formatting for EntitySchema values

https://gerrit.wikimedia.org/r/1023082

gerritbot added a comment.Thu, Apr 25, 4:27 PM

Change #994206 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Use custom entity schema value parser

https://gerrit.wikimedia.org/r/994206

gerritbot added a comment.Thu, Apr 25, 4:30 PM

Change #1007655 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Register entity schema data type for clients

https://gerrit.wikimedia.org/r/1007655

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Thu, Apr 25, 5:00 PM
ArthurTaylor reassigned this task from ArthurTaylor to • Lucas_Werkmeister_WMDE.Fri, Apr 26, 10:04 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
gerritbot added a comment.Tue, Apr 30, 9:43 AM

Change #1023082 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Add formatting for EntitySchema values

https://gerrit.wikimedia.org/r/1023082

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Tue, Apr 30, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 30, 10:30 AM
ArthurTaylor added a comment.EditedTue, Apr 30, 10:41 AM

Tried to test this on beta now with:

{"type":"statement","mainsnak":{"snaktype":"value","property":"P253077","datavalue":{"type":"wikibase-entityid","value":{"id":"E10"}}},"id":"P253077$96461d0e-06dd-11ef-9fbf-8b25ca3a3caf","rank":"normal"}

I get the message that my user doesn't have permission to make edits in the property namespace:

{
    "error": {
        "code": "failed-save",
        "info": "The save has failed.",
        "messages": [
            {
                "name": "wikibase-api-failed-save",
                "parameters": [],
                "html": "The save has failed."
            },
            {
                "name": "namespaceprotected",
                "parameters": [
                    "Property",
                    "edit"
                ],
                "html": "You do not have permission to edit pages in the <strong>Property</strong> namespace."
            },
            {
                "name": "permissionserrors",
                "parameters": [],
                "html": "Permission error"
            }
        ],
        "docref": "See https://wikidata.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/&gt; for notice of API deprecations and breaking changes."
    },
    "servedby": "deployment-mediawiki11"
}

@Lucas_Werkmeister_WMDE do you have permission?

hoo subscribed.Tue, Apr 30, 2:08 PM
In T362001#9757106, @ArthurTaylor wrote:

[…]
I get the message that my user doesn't have permission to make edits in the property namespace:
[…]
@Lucas_Werkmeister_WMDE do you have permission?

You can just try the edit on an item, by changing the claim's "id", eg. to Q584208$6dcf36c9-238a-435b-8ead-6fd1915b8548 to edit item Q584208. Also I made you an administrator on beta Wikidata now… while not needed here, it could come in handy sometime.

I submitted an edit with the same statement (on a different entity) and got:

{
	"error": {
		"code": "modification-failed",
		"info": "Data value corrupt: Can not parse id 'E1' to build EntityIdValue with",
		"messages": [
			{
				"name": "wikibase-validator-bad-value",
				"parameters": [
					"Can not parse id 'E1' to build EntityIdValue with"
				],
				"html": {
					"*": "Data value corrupt: Can not parse id 'E1' to build EntityIdValue with"
				}
			}
		],
		"*": "See https://wikidata.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/&gt; for notice of API deprecations and breaking changes."
	}
}
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL