Page MenuHomePhabricator
Create Task
Maniphest T362221

PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::addTemplate with interwiki link was deprecated in MediaWiki 1.42. [Called from MediaWiki\Parser\Parser::fetchTemplateAndTitle]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::addTemplate with interwiki link was deprecated in MediaWiki 1.42. [Called from MediaWiki\Parser\Parser::fetchTemplateAndTitle]
error.stack_trace
from /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3594)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(379): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(350): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(231): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.26/includes/GlobalFunctions.php(773): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/ParserOutput.php(1107): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3594): MediaWiki\Parser\ParserOutput->addTemplate(MediaWiki\Title\Title, integer, NULL)
#7 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3478): MediaWiki\Parser\Parser->fetchTemplateAndTitle(MediaWiki\Title\Title)
#8 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3219): MediaWiki\Parser\Parser->getTemplateDom(MediaWiki\Title\Title)
#9 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/PPFrame_Hash.php(275): MediaWiki\Parser\Parser->braceSubstitution(array, PPFrame_Hash)
#10 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(2937): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#11 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(1583): MediaWiki\Parser\Parser->replaceVariables(string)
#12 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(691): MediaWiki\Parser\Parser->internalParse(string)
#13 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/WikitextContentHandler.php(376): MediaWiki\Parser\Parser->parse(string, MediaWiki\Title\Title, ParserOptions, boolean, boolean, NULL)
#14 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/ContentHandler.php(1664): WikitextContentHandler->fillParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#15 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/Renderer/ContentRenderer.php(67): ContentHandler->getParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#16 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiParse.php(161): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, MediaWiki\Title\Title, NULL, ParserOptions)
#17 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolCounterWorkViaCallback.php(73): ApiParse->{closure}()
#18 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolCounterWork.php(171): MediaWiki\PoolCounter\PoolCounterWorkViaCallback->doWork()
#19 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiParse.php(169): MediaWiki\PoolCounter\PoolCounterWork->execute()
#20 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiParse.php(446): ApiParse->getContentParserOutput(WikitextContent, MediaWiki\Title\Title, NULL, ParserOptions)
#21 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiMain.php(1946): ApiParse->execute()
#22 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiMain.php(922): ApiMain->executeAction()
#23 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiMain.php(893): ApiMain->executeActionWithErrorHandling()
#24 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiEntryPoint.php(158): ApiMain->execute()
#25 /srv/mediawiki/php-1.42.0-wmf.26/includes/MediaWikiEntryPoint.php(199): MediaWiki\Api\ApiEntryPoint->execute()
#26 /srv/mediawiki/php-1.42.0-wmf.26/api.php(44): MediaWiki\MediaWikiEntryPoint->run()
#27 /srv/mediawiki/w/api.php(3): require(string)
#28 {main}
Impact
Notes

New from 1.42.0-wmf.26 they are all from meta.wikimedia.org and specially all from the User namespace?

MediaWiki\Parser\ParserOutput::addTemplate with interwikilink has been deprecated via T361330

Details

Request URL
https://meta.wikimedia.org/w/api.php?action=parse&title=*&text=*&disableeditsection=*&disablelimitreport=*&uselang=*&useskin=*&prop=*&formatversion=*&format=*
SubjectRepoBranchLines +/-
Parser::statelessFetchTemplate: don't add interwiki redirects to dependenciesmediawiki/coremaster+24 -12
Parser::statelessFetchTemplate: don't add interwiki redirects to dependenciesmediawiki/corewmf/1.42.0-wmf.26+24 -12
Parser::statelessFetchTemplate: don't add interwiki redirects to dependenciesmediawiki/coreREL1_42+24 -12
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Apr 10 2024, 11:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2024, 11:37 AM
cscott subscribed.Apr 10 2024, 2:20 PM

Hm, could this be part of https://www.mediawiki.org/wiki/Extension:GlobalUserPage ? Although it's weird that it's coming in via an API request.

Can reproduce with:

https://meta.wikimedia.org/wiki/Special:ApiSandbox#action=parse&format=json&uselang=eo&title=User%3ABe..anyone&text=%7B%7B%3AUser%3ABe..anyone%7D%7D&prop=text%7Cmodules%7Cjsconfigvars%7Cindicators%7Csections%7Cexternallinks&disablelimitreport=1&disableeditsection=1&useskin=vector-2022&formatversion=2

cscott added a comment.Apr 10 2024, 2:32 PM

Yeah, the requests are definitely coming from the GlobalUserPage extension: https://codesearch.wmcloud.org/search/?q=GlobalUserPageAPIUrl&files=&excludeFiles=&repos=

All of the pages seem to contain a #REDIRECT to a non-local wiki, which is where the user's "real" home page is. Verified that {{:User:cscott}} (which doesn't contain a #REDIRECT) doesn't trigger this, even though https://meta.wikimedia.org/wiki/User:cscott contains a non-local link. So probably an issue with redirect handling to non-local pages.

cscott added a comment.EditedApr 10 2024, 2:58 PM

It's specifically a local transclusion of a page with a #REDIRECT, it doesn't happen if you put the #REDIRECT directly in the action=parse&text=.... request, nor does it happen if the page you are transcluding includes a interwiki link but not as a #REDIRECT. So probably something about how #REDIRECT is handled as a magic word when it is *not* stripped by WikitextContentHandler::extractRedirectTargetAndText. Also happens if parsoid=1 in the API request, oddly (?) enough, since Parsoid by default (a) doesn't strip the #REDIRECT and (b) handles the #REDIRECT locally (generating a <link>) rather than calling the core magic word. Hmm. The stack trace in the Parsoid case is:

from /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3594)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(379): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(350): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.42.0-wmf.26/includes/debug/MWDebug.php(231): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.42.0-wmf.26/includes/GlobalFunctions.php(773): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/ParserOutput.php(1107): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3594): MediaWiki\Parser\ParserOutput->addTemplate(MediaWiki\Title\Title, integer, NULL)
#7 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3478): MediaWiki\Parser\Parser->fetchTemplateAndTitle(MediaWiki\Title\Title)
#8 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(3219): MediaWiki\Parser\Parser->getTemplateDom(MediaWiki\Title\Title)
#9 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/PPFrame_Hash.php(275): MediaWiki\Parser\Parser->braceSubstitution(array, PPFrame_Hash)
#10 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parser.php(2937): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#11 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parsoid/Config/DataAccess.php(386): MediaWiki\Parser\Parser->replaceVariables(string, PPFrame_Hash)
#12 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wikitext/Wikitext.php(43): MediaWiki\Parser\Parsoid\Config\DataAccess->preprocessWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOutput, string)
#13 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1067): Wikimedia\Parsoid\Wikitext\Wikitext::preprocess(Wikimedia\Parsoid\Config\Env, string)
#14 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1110): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->expandTemplate(Wikimedia\Parsoid\Wt2Html\TT\TemplateEncapsulator)
#15 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1151): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTemplate(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#16 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(138): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#17 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(113): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#18 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(176): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#19 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(174): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#20 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/TreeBuilder/TreeBuilderStage.php(476): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#21 [internal function]: Wikimedia\Parsoid\Wt2Html\TreeBuilder\TreeBuilderStage->processChunkily(string, array)
#22 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(963): Generator->current()
#23 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(170): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#24 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(279): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#25 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(159): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#26 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Parsoid.php(191): Wikimedia\Parsoid\Wikitext\ContentModelHandler->toDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI)
#27 /srv/mediawiki/php-1.42.0-wmf.26/vendor/wikimedia/parsoid/src/Parsoid.php(232): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOutput, array)
#28 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parsoid/ParsoidParser.php(149): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, NULL, MediaWiki\Parser\ParserOutput)
#29 /srv/mediawiki/php-1.42.0-wmf.26/includes/parser/Parsoid/ParsoidParser.php(253): MediaWiki\Parser\Parsoid\ParsoidParser->genParserOutput(MediaWiki\Parser\Parsoid\Config\PageConfig, ParserOptions)
#30 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/WikitextContentHandler.php(376): MediaWiki\Parser\Parsoid\ParsoidParser->parse(string, MediaWiki\Title\Title, ParserOptions, boolean, boolean, NULL)
#31 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/ContentHandler.php(1664): WikitextContentHandler->fillParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#32 /srv/mediawiki/php-1.42.0-wmf.26/includes/content/Renderer/ContentRenderer.php(67): ContentHandler->getParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#33 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiParse.php(161): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, MediaWiki\Title\Title, NULL, ParserOptions)
#34 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolCounterWorkViaCallback.php(73): ApiParse->{closure}()
#35 /srv/mediawiki/php-1.42.0-wmf.26/includes/poolcounter/PoolCounterWork.php(171): MediaWiki\PoolCounter\PoolCounterWorkViaCallback->doWork()
#36 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiParse.php(169): MediaWiki\PoolCounter\PoolCounterWork->execute()
#37 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiParse.php(446): ApiParse->getContentParserOutput(WikitextContent, MediaWiki\Title\Title, NULL, ParserOptions)
#38 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiMain.php(1946): ApiParse->execute()
#39 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiMain.php(922): ApiMain->executeAction()
#40 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiMain.php(893): ApiMain->executeActionWithErrorHandling()
#41 /srv/mediawiki/php-1.42.0-wmf.26/includes/api/ApiEntryPoint.php(158): ApiMain->execute()
#42 /srv/mediawiki/php-1.42.0-wmf.26/includes/MediaWikiEntryPoint.php(199): MediaWiki\Api\ApiEntryPoint->execute()
#43 /srv/mediawiki/php-1.42.0-wmf.26/api.php(44): MediaWiki\MediaWikiEntryPoint->run()
#44 /srv/mediawiki/w/api.php(3): require(string)
#45 {main}
cscott added a comment.Apr 10 2024, 3:26 PM

The root cause is the redirect resolution inside Parser:statelessFetchTemplate which follows (a limited number of) redirects in order to obtain the "real" template text. It adds each step in the redirect chain to the page dependencies as it goes. The issue is that when redirects point to interwiki links, it goes ahead and adds those external links to the dependencies as well, which eventually causes them to be sent to ParserOutput::addTemplate(). As discussed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LabeledSectionTransclusion/+/1004305:

At the moment the call to Parser::fetchTemplateAndTitle (directly or via Parser::getTemplateDom) would register the interwiki as template via ParserOutput::addTemplate and it gets stored in the linktarget table with ns=0 and title=Non-Wiki-Part. When this is a interwiki to a user page, the linktarget has ns=0 and title=User:Name and namespaceDupes.php wants to repair this (the way I have seen this - T355706).

gerritbot added a comment.Apr 10 2024, 3:28 PM

Change #1018732 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies

https://gerrit.wikimedia.org/r/1018732

gerritbot added a project: Patch-For-Review.Apr 10 2024, 3:28 PM
cscott mentioned this in T362222: PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::addTemplate with interwiki link was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\Scribunto\Engines\LuaCommon\TitleLibrary::getContentInternal].Apr 10 2024, 3:35 PM
gerritbot added a comment.Apr 10 2024, 4:54 PM

Change #1018732 merged by jenkins-bot:

[mediawiki/core@master] Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies

https://gerrit.wikimedia.org/r/1018732

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 10 2024, 5:00 PM
gerritbot added a comment.Apr 10 2024, 6:10 PM

Change #1018692 had a related patch set uploaded (by Jforrester; author: C. Scott Ananian):

[mediawiki/core@wmf/1.42.0-wmf.26] Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies

https://gerrit.wikimedia.org/r/1018692

gerritbot added a comment.Apr 10 2024, 6:10 PM

Change #1018693 had a related patch set uploaded (by Jforrester; author: C. Scott Ananian):

[mediawiki/core@REL1_42] Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies

https://gerrit.wikimedia.org/r/1018693

MSantos edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.Apr 11 2024, 2:02 PM
gerritbot added a comment.Apr 11 2024, 10:00 PM

Change #1018693 merged by jenkins-bot:

[mediawiki/core@REL1_42] Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies

https://gerrit.wikimedia.org/r/1018693

ReleaseTaggerBot added a project: MW-1.42-notes.Apr 11 2024, 11:00 PM
gerritbot added a comment.Apr 12 2024, 2:01 PM

Change #1018692 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.26] Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies

https://gerrit.wikimedia.org/r/1018692

Stashbot added a comment.Apr 12 2024, 2:05 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-12T14:05:43Z] <hashar@deploy1002> Started scap: Backport for [[gerrit:1018692|Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies (T362221)]]

Stashbot added a comment.Apr 12 2024, 2:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-12T14:08:16Z] <hashar@deploy1002> hashar and jforrester: Backport for [[gerrit:1018692|Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies (T362221)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Apr 12 2024, 2:22 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-12T14:22:12Z] <hashar@deploy1002> Finished scap: Backport for [[gerrit:1018692|Parser::statelessFetchTemplate: don't add interwiki redirects to dependencies (T362221)]] (duration: 16m 29s)

hashar closed this task as Resolved.EditedApr 12 2024, 2:24 PM
hashar assigned this task to cscott.

I have deployed the fix and, thanks to the reproducible case, I can confirm that fixed that specific error log :) Thank you!

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.26; 2024-04-09); removed MW-1.42-notes.Apr 12 2024, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits