Page MenuHomePhabricator

Table: add single sort
Closed, ResolvedPublic

Description

Table subtasks to enable sorting of rows (Step 2)

Add single sort

  • Add the sort prop to Table
  • New interface type: string: ‘none’|’asc’|’desc’
  • Handling sort icon click
  • Updating the sort prop via an event
  • Changing the sort icon
  • If a column was sorted, it should become unsorted
  • Include a11y features
  • Update the initial demo to actually do sorting (could be a separate patch)
  • Add unit tests

Related Objects

Event Timeline

Change #1020875 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Table: Add demo for single sort

https://gerrit.wikimedia.org/r/1020875

Change #1020895 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] Table: add single sort

https://gerrit.wikimedia.org/r/1020895

Change #1020875 abandoned by LWatson:

[design/codex@main] Table: Add demo for single sort

Reason:

Included these changes in patch: 1020895

https://gerrit.wikimedia.org/r/1020875

lwatson changed the task status from Open to In Progress.Fri, Apr 26, 11:13 PM

Change #1020895 merged by jenkins-bot:

[design/codex@main] Table: add single sort

https://gerrit.wikimedia.org/r/1020895

Change #1025849 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849

Change #1025849 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849