Page MenuHomePhabricator
Create Task
Maniphest T362771

Move ReferencePreviews related config flags to Cite's codebase
Open, Stalled, Needs TriagePublic
Actions

Description

The Page-Previews extension currently manages a JS global wgPopupsFlags [1] that mainly holds data about settings related to the Reference Previews feature. The code now moved to the Cite extension and so most of these settings should be set there.

Implementation plan:

  • Add gadget detection [2] for ReferenceTooltips and NavigationPopups to Cite's codebase and disable the preview in these cases. ( Use the existing wgPopupsConflictingRefTooltipsGadgetName and wgPopupsConflictingNavPopupsGadgetName settings )
  • Move the code for detecting the user setting wgPopupsReferencePreviews to the Cite codebase. [3]
  • Create Cite specific copies for the relevant gadget and feature switch setting globals
  • Cleanup the settings and flag code in the Popups extension. Note, that the detection for NavigationPopups is still relevant for popups
  • Rename the wgPopupsConflictingRefTooltipsGadgetName config setting and move it to Cite [4]. It's only relevant for Reference Previews .
  • Remove irrelevant global config copies when changes are deployed on production.

Note:

  • We can use the onMakeGlobalVariablesScript hook to set JS vars where we need the user object like done in the Popups extension.

[1] https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/03449d1af07d25561d2abfeeff5763d5d3fad55e/includes/PopupsHooks.php#246
[2] https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/03449d1af07d25561d2abfeeff5763d5d3fad55e/includes/PopupsGadgetsIntegration.php
[3] https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/03449d1af07d25561d2abfeeff5763d5d3fad55e/includes/PopupsContext.php#152
[4] https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/03449d1af07d25561d2abfeeff5763d5d3fad55e/extension.json#74

Details

SubjectRepoBranchLines +/-
Separate names for server-side vs. client-side feature flagsmediawiki/extensions/Citemaster+15 -14
Add ReferencePreviews config checks to Cite extensionmediawiki/extensions/Citemaster+449 -219
Set conflicting gadget settings for the Cite extensionoperations/mediawiki-configmaster+13 -0
Zuul: [mediawiki/extensions/Cite] Add Gadgets as general dependencyintegration/configmaster+2 -1
Zuul: [mediawiki/extensions/Cite] Add Gadgets phan dependencyintegration/configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Wed, Apr 17, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Apr 17, 11:53 AM
WMDE-Fisch renamed this task from Move ReferenceTooltips detection to Cite's ReferencePreviews to Move ReferencePreviews related config flags to Cite's codebase.Thu, Apr 18, 10:39 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch updated the task description. (Show Details)Thu, Apr 18, 10:43 AM
thiemowmde subscribed.Thu, Apr 18, 12:09 PM
WMDE-Fisch claimed this task.Thu, Apr 18, 12:40 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2024-04-12 board.
gerritbot added a comment.Mon, Apr 22, 5:45 PM

Change #1023115 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Add ReferencePreviews config checks to Cite extension

https://gerrit.wikimedia.org/r/1023115

gerritbot added a project: Patch-For-Review.Mon, Apr 22, 5:45 PM
WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2024-04-12 board.Mon, Apr 22, 5:49 PM
gerritbot added a comment.Mon, Apr 22, 6:18 PM

Change #1023117 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[integration/config@master] Add Gadgets to Cite phan config

https://gerrit.wikimedia.org/r/1023117

gerritbot added a comment.Tue, Apr 23, 12:02 PM

Change #1023117 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Cite] Add Gadgets phan dependency

https://gerrit.wikimedia.org/r/1023117

gerritbot added a comment.Tue, Apr 23, 3:04 PM

Change #1023448 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[integration/config@master] Zuul: [mediawiki/extensions/Cite] Add Gadgets as general dependency

https://gerrit.wikimedia.org/r/1023448

gerritbot added a comment.Wed, Apr 24, 7:10 AM

Change #1023448 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Cite] Add Gadgets as general dependency

https://gerrit.wikimedia.org/r/1023448

thiemowmde added a project: WMDE-TechWish-Sprint-2024-04-24.Wed, Apr 24, 12:12 PM
awight moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2024-04-24 board.Wed, Apr 24, 12:20 PM
awight moved this task from Demo to Tech Review on the WMDE-TechWish-Sprint-2024-04-24 board.
WMDE-Fisch updated the task description. (Show Details)Thu, Apr 25, 9:34 AM
gerritbot added a comment.Thu, Apr 25, 9:50 AM

Change #1024345 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[operations/mediawiki-config@master] Set conflicting gadget settings for the Cite extension

https://gerrit.wikimedia.org/r/1024345

gerritbot added a comment.Thu, Apr 25, 1:22 PM

Change #1024345 merged by jenkins-bot:

[operations/mediawiki-config@master] Set conflicting gadget settings for the Cite extension

https://gerrit.wikimedia.org/r/1024345

Stashbot added a comment.Thu, Apr 25, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-25T13:22:59Z] <cgoubert@deploy1002> Started scap: Backport for [[gerrit:1024345|Set conflicting gadget settings for the Cite extension (T362771)]]

Stashbot added a comment.Thu, Apr 25, 1:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-25T13:26:17Z] <cgoubert@deploy1002> cgoubert and wmde-fisch: Backport for [[gerrit:1024345|Set conflicting gadget settings for the Cite extension (T362771)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Thu, Apr 25, 1:44 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-25T13:44:33Z] <cgoubert@deploy1002> Finished scap: Backport for [[gerrit:1024345|Set conflicting gadget settings for the Cite extension (T362771)]] (duration: 21m 33s)

gerritbot added a comment.Thu, Apr 25, 2:43 PM

Change #1023115 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add ReferencePreviews config checks to Cite extension

https://gerrit.wikimedia.org/r/1023115

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Thu, Apr 25, 3:00 PM
WMDE-Fisch removed a project: Patch-For-Review.Fri, Apr 26, 10:46 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch changed the task status from Open to Stalled.Fri, Apr 26, 10:49 AM
WMDE-Fisch moved this task from Tech Review to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-04-24 board.

Waiting for 1.43.0-wmf.3 deployment for the next steps.

gerritbot added a comment.Tue, Apr 30, 9:59 AM

Change #1025702 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Separate names for server-side vs. client-side feature flags

https://gerrit.wikimedia.org/r/1025702

gerritbot added a project: Patch-For-Review.Tue, Apr 30, 9:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL