Page MenuHomePhabricator

Notifications are not usable on mobile version of RTL
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • On mobile device visit RTL wiki e.g .(arwiki and arzwiki)
  • Log in
  • Make sure screen is resized to mobile-resolution e.g. 400px.
  • Click the notification icon button,

Expected results

Notifications appear

Actual results

the notifications do not appear (like in a screenshot).

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): MediaWiki 1.43/wmf.1

Other information (browser name/version, screenshots, etc.):

Screenshot_20240419-115032_Kiwi Browser.png (1×720 px, 104 KB)

QA Results - Beta

ACStatusDetails
1T362986#9759110

QA Results - PROD

ACStatusDetails
1T362986#9759438

Event Timeline

Gerges triaged this task as High priority.Apr 19 2024, 3:25 PM
Aklapper raised the priority of this task from High to Needs Triage.Apr 19 2024, 4:51 PM

@GergesSH Hi, do you plan to work on fixing this task, as you increased the priority of this task?

Thanks for unprioritizing @Aklapper - prioritized tickets skip our triaging process so we weren't seeing this until now.

Changing .notifications-overlay.navigation-drawer { left: 0; } to .notifications-overlay.navigation-drawer { right: 0; } fixes this. I'm not seeing any issues in CSS Janus so not sure why this has suddenly arisen on first glance. We'll need to do some more digging.

Gerges triaged this task as Unbreak Now! priority.Apr 21 2024, 8:29 AM

Sorry @Aklapper, I changed the priority by mistake.

RhinosF1 lowered the priority of this task from Unbreak Now! to Needs Triage.Apr 21 2024, 9:06 AM
ovasileva triaged this task as Unbreak Now! priority.Apr 23 2024, 4:23 PM
Jdlrobson renamed this task from Notifications do not appear well on the mobile version of RTL to Notifications are not usable on mobile version of RTL.Apr 23 2024, 4:45 PM
ovasileva set the point value for this task to 3.Apr 23 2024, 4:46 PM
ovasileva moved this task from Backlog to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.

Change #1023481 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Use dedicated Codex style modules

https://gerrit.wikimedia.org/r/1023481

Change #1023157 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.43.0-wmf.1] Use dedicated Codex style modules

https://gerrit.wikimedia.org/r/1023157

Change #1023158 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.43.0-wmf.2] Use dedicated Codex style modules

https://gerrit.wikimedia.org/r/1023158

Change #1023481 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use dedicated Codex style modules

https://gerrit.wikimedia.org/r/1023481

Change #1023158 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.43.0-wmf.2] Use dedicated Codex style modules

https://gerrit.wikimedia.org/r/1023158

Change #1023157 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.43.0-wmf.1] Use dedicated Codex style modules

https://gerrit.wikimedia.org/r/1023157

Mentioned in SAL (#wikimedia-operations) [2024-04-23T20:36:27Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:1023160|.nvmrc: Update version from 18.17.0 to 18.20.2]], [[gerrit:1023157|Use dedicated Codex style modules (T362986)]], [[gerrit:1023158|Use dedicated Codex style modules (T362986)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-23T20:39:03Z] <zabe@deploy1002> zabe and jdlrobson: Backport for [[gerrit:1023160|.nvmrc: Update version from 18.17.0 to 18.20.2]], [[gerrit:1023157|Use dedicated Codex style modules (T362986)]], [[gerrit:1023158|Use dedicated Codex style modules (T362986)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-23T21:01:00Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:1023160|.nvmrc: Update version from 18.17.0 to 18.20.2]], [[gerrit:1023157|Use dedicated Codex style modules (T362986)]], [[gerrit:1023158|Use dedicated Codex style modules (T362986)]] (duration: 24m 32s)

Jdlrobson lowered the priority of this task from Unbreak Now! to High.
Edtadros removed Edtadros as the assignee of this task.EditedApr 30 2024, 6:34 PM
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

On mobile device visit RTL wiki e.g .(arwiki and arzwiki)
Log in
Make sure screen is resized to mobile-resolution e.g. 400px.
Click the notification icon button,
✅ AC1: Notifications appear

screenshot 53.mov.gif (844×388 px, 398 KB)

screenshot 54.mov.gif (844×388 px, 145 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.4.1
Browser: Chrome 124
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

On mobile device visit RTL wiki e.g .(arwiki and arzwiki)
Log in
Make sure screen is resized to mobile-resolution e.g. 400px.
Click the notification icon button,
✅ AC1: Notifications appear
Test Link: https://ar.m.wikipedia.org/wiki/%D9%83%D9%84%D8%A8

2024-04-30_12-51-18 (1).gif (768×354 px, 1 MB)

ovasileva claimed this task.

Looks good. Resolving. Thanks again for the report @GergesSH!