Page MenuHomePhabricator

[envvars-api, envvars-cli] Prefix all endpoints with `/tool/<toolname>`
Closed, ResolvedPublic

Description

Otherwise once we have authentication per-user, we would not be able to know which tool they are acting on (today we authenticate with the tool certificate, so the authenticated user is the tool itself).

Note that the procedure to avoid downtime can be:

  • Change API to support both endpoints (add a check in the API between the path and the auth user for consistency for now)
  • Change the client to use the new url
  • Remove support for the non-prefixed url on the api side

Related Objects

StatusSubtypeAssignedTask
ResolvedLucasWerkmeister
Resolvedmatmarex
ResolvedLegoktm
ResolvedLegoktm
In Progressdcaro
Resolveddcaro
In Progresskomla
Resolveddcaro
Resolveddcaro
Resolveddcaro
Opendcaro
Resolveddcaro
Opendcaro
Opendcaro
Resolveddcaro
ResolvedSlst2020
ResolvedSlst2020

Event Timeline

dcaro removed dcaro as the assignee of this task.Apr 30 2024, 10:07 AM
dcaro triaged this task as High priority.
dcaro moved this task from Backlog to Ready to be worked on on the Toolforge board.
Slst2020 changed the task status from Open to In Progress.May 30 2024, 12:38 PM
Slst2020 claimed this task.
Slst2020 moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 10) board.
Slst2020 renamed this task from [envvars-api] Prefix all endpoints with `/tool/<toolname>` to [envvars-api, envvars-cli] Prefix all endpoints with `/tool/<toolname>`.Jun 3 2024, 12:50 PM
Slst2020 updated the task description. (Show Details)

project_1317_bot_df3177307bed93c3f34e421e26c86e38 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/310

envvars-api: bump to 0.0.46-20240605083025-b81e0804